Brave-browser: Option to clear browsing data on exit

[srirambv]

Test plan

See https://github.com/brave/brave-core/pull/1213

Description

Brave-core doesn't have an option to clear browsing history/cache upon browser exit. It would be great to have this option to bridge parity between browser-laptop and brave-core

[eljuno]

+1 from community https://community.brave.com/t/clear-data-on-close-missing/33647?u=eljuno

[diracdeltas]

+1 from me, i use this in b-l

[NumDeP]

+1 For your information, when this feature is implemented, create numerous tests to check whether selected data has actually cleared on exit. On the Muon-Linux version, I had to manually click the orange 'Clear Browsing Data Now...' for it to prompt Restart Browser Now and clicking it every time for it to actually erase data on exit, which it did afterwards but never did it erase properly by just leaving it on Clear data on exit.

One way I noticed is when certain sites would show numerous familiar content and another easy way to deduce it was checking to see if recent links on a search engine were still highlighted (purple)

[eljuno]

+1 from community https://community.brave.com/t/clear-cache-and-cookies-on-application-exit-does-version-0-55-still-have-this-feature/36938?u=eljuno

[NejcZdovc]

+1 from me

[warwickmm]

+1 from me

[eljuno]

+1 from Community https://community.brave.com/t/auto-clear-browsing-data/38042?u=eljuno

[srirambv]

+1 from https://community.brave.com/t/download-muon-version-025/38181/

[srirambv]

+1 from https://community.brave.com/t/bring-back-clear-on-close/38214

[srirambv]

@kjozwiak @rebron @bbondy we need to prioritize this as well. Been seeing a lot of +1's from community.

[kjozwiak]

Thanks @srirambv 👍 We'll triage this Tuesday during our b-c triage meeting when we go through all the GH boards. I know that @BrendanEich also mentioned that there's a few +1 from Twitter as well.

https://github.com/brave/browser-android-tabs/issues/93 has been created on android a while back and gets a good amount of +1 as well.

[Brave-Matt]

Just added one to that very thread

[diracdeltas]

un-assigning @jumde since he is on PTO right now and we probably want it done in the meantime

[diracdeltas]

note that due to https://github.com/brave/brave-browser/issues/2400, clearing all history could clear the shield settings

[eljuno]

+1 from Community https://community.brave.com/t/clear-cookies-on-exit/39920?u=eljuno

[FrederickDavies]

+1
In fact I am not using Brave Core until this is implemented and it works (I have seen stuff being left behind after I close Brave Muon despite the "delete on exit" options being enabled).

[NumDeP]

@FrederickDavies I once reported the issue last year in the Muon version and again in a comment above. I thought it might have been a tracking bug and reported the issue here - https://github.com/brave/browser-laptop/issues/12449 but I'm almost certain there was a bug in the cleaning process like you and I stated above.

[gpklinedinst]

+1
Please implement this feature ASAP. It is critical to working in a secure manner. Relying on the user to click through the "delete cookies" after every visit to a social media site is unrealistic and error prone. I've gotten used to just closing the browser and having a "clean slate" when I start it again. I'm going to try to find an old version of Brave until this is remedied.

[eljuno]

+1 from Community https://community.brave.com/t/add-back-deleting-history-on-exit/41443?u=eljuno

[FatOrangutan]

To people leaving +1 comments: could you not 👍 the original post?
To community moderators leaving +1 from community [link] comments: could you not edit one of your earlier similar comments to include the latest community link?

Subscribing to issues on any of the Brave repos is kind of frustrating because these two comments make for the majority of notifications I receive. Thanks and sorry for yet another useless notification.

[FrederickDavies]

FatOrangutan,
Now done.
FD

[alvinometric]

+1 from me too

[JoeBloggs2345]

Can't wait for this!

[ghug]

'Clear browsing history on exit' doesn't currently override the brave://settings/onStartup setting. If onStartup is set to "Continue where you left off" any open tabs are still remembered and re-opened on startup even if browsing history is cleared on exit. Perhaps this is intended, but it doesn't seem completely intuitive to me.

[rebron]

@gabrielhug I don't think 'Clear browsing history on exit' should override that on start up setting. People can change that setting back to New Tab page or a page/set of pages they want instead.

[FrederickDavies]

Is something like this (options to delete stuff on exit) going to be implemented on the Android version of Brave?

FD

[bsclifton]

@FrederickDavies good question -
Looks like it's being tracked with https://github.com/brave/browser-android-tabs/issues/93 in case you wanted to give it a thumbs up 😄

cc: @anthonypkeane @SergeyZhukovsky

[FrederickDavies]

How do you find out when the fix is due to come out into the Brave Core auto-update stream?

FD

[kjozwiak]

How do you find out when the fix is due to come out into the Brave Core auto-update stream?

FD

Here's a few methods/checks that you can use to see where a certain fix is landing:

• Check the milestone of the issue. In this case, it's set as 0.63.x. If you take a look at https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule, 0.63.x will be released on ~April 23, 2019
• Same as above, check the milestone on the PR that fixed this issue. In this case, https://github.com/brave/brave-core/pull/1213 is labelled as 0.63.x as well. As mentioned above, 0.63.x is slated to be released on April 23, 2019.

With the above information, you know that it's landing in 0.63.x, as a double check, you can make sure that the PR is appearing in the 0.63.x tree:

• https://github.com/brave/brave-core/tree/0.63.x

[FrederickDavies]

Thank you!

            FD

From: Kamil Jozwiak [mailto:[email protected]]
Sent: 20 March 2019 02:48
To: brave/brave-browser [e-mail]
Cc: FrederickDavies [e-mail]; Mention [e-mail]
Subject: Re: [brave/brave-browser] Option to clear history/cache when browser closed/quit (#492)

How do you find out when the fix is due to come out into the Brave Core auto-update stream?

FD

Here's a few methods/checks that you can use to see where a certain fix is landing:

• Check the milestone of the issue. In this case, it's set as 0.63.x. If you take a look at https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule, 0.63.x will be released on ~April 23, 2019
• Same as above, check the milestone on the PR that fixed this issue. In this case, brave/brave-core#1213https://github.com/brave/brave-core/pull/1213 is labelled as 0.63.x as well. As mentioned above, 0.63.x is slated to be released on April 23, 2019.

With the above information, you know that it's landing in 0.63.x, as a double check, you can make sure that the PR is appearing in the 0.63.x tree:

• https://github.com/brave/brave-core/tree/0.63.x

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/brave/brave-browser/issues/492#issuecomment-474662959, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVfM3NeL5IIbouzV3gJQTSRfqRKs_y1Oks5vYaFhgaJpZM4VEkub.

[babbage1986]

There is a Chrome extension, Click&Clean, which does this job perfectly but it does not run on Brave (I think it does run on the Dev release). Please can we activate this extension and solve the issue.

[srirambv]

Verification passed on

Brave | 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Linux

• Verified all test scenarios mentioned in https://github.com/brave/brave-core/pull/1213

Verification passed on

Brave | 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Windows 10 OS Build 17134.523

• Used test plan from https://github.com/brave/brave-core/pull/1213

Verified passed with

Brave | 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
-- | --
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X

• Verified test plan from https://github.com/brave/brave-core/pull/1213
• For tests 1-7, also performed clearing data from 'Advanced' tab (on a clean profile) to verify that clearing each item individually and manually from Advanced worked the same as clearing on exit.
• Encountered #4004 while testing.

[babbage1986]

Thanks! Click&Clean now works. Better still the new settings illustrated above are the ideal solution.

[balupton]

What's the latest for this?

Nevermind, found it.

I hope however this can be an ever-present selection, such that the browser always deletes everything on exit.

[babbage1986]

This is pretty much out of date. I no longer use the Click&Clean extension, the settings in Brave do what I need, i.e., on exit delete all cookies except those I explicitly specify. If Safari had this option I'd switch but it doesn't.

[FrederickDavies]

It seems the Android ticket has disappeared; anyone know if there is something like this (options to delete stuff on exit) on the Android version of Brave?

FD