Bookmarks: Bookmarklet doesn't recognize already bookmarked urls with urlencoded chars

[marcelklehr]

[marcelklehr]

As a cause, this neat, useless-looking line of code catches the eye: https://github.com/nextcloud/bookmarks/blob/master/controller/lib/bookmarks.php#L128

[marcelklehr]

Mh @blizzz I cannot reproduce this with master?

[blizzz]

Does not work with this page for me: https://fr.wikipedia.org/wiki/Correspondance_entre_logiciels_libres_et_logiciels_propri%C3%A9taires

[marcelklehr]

Ah, ok. It's an encoding/matching problem.

The bookmarklet directs you to:

http://localhost:8008/index.php/apps/bookmarks/bookmarklet?...%2Fwiki%2FCorrespondance_entre_logiciels_libres_et_logiciels_propri%25C3%25A9taires&title=Correspondance%20entre%20logiciels%20libres%20et%20logiciels%20propri%C3%A9taires%20%E2%80%94%20Wikip%C3%A9dia

where the url is read as: .../wiki/Correspondance_entre_logiciels_libres_et_logiciels_propri%C3%A9taires

-- since the server code looks for exact matches, it doesn't find the existing bookmark.

Whereas if you go to

http://localhost:8008/index.php/apps/bookmarks/bookmarklet?...%2Fwiki%2FCorrespondance_entre_logiciels_libres_et_logiciels_propri%C3%A9taires&title=Correspondance%20entre%20logiciels%20libres%20et%20logiciels%20propri%C3%A9taires%20%E2%80%94%20Wikip%C3%A9dia

the URL is read as: .../wiki/Correspondance_entre_logiciels_libres_et_logiciels_propriétaires

and the boorkmark is found.

[marcelklehr]

@xXSTrikeXx Any reason for moving this back to 'backlog'? :)

[xXSTrikeXx]

Holding a smartphone in the hands while walking :D Sry I thought i have undone my fault for using github on smartphone in a browser 🥇 :/ I hope its not to late to apologize :)

Edit: Undone it now correctly. Sorry for confusing you :D

[marcelklehr]

No worries. I know the feeling. Github on mobile is like minimally invasive surgery with your bare hands :)

[xXSTrikeXx]

My friend next to me reading this - he´s studying medicine - is ROFL due to that comparison with Github :D :D