Bookmarks: Webui becomes non-responsive when "Select All" with over 1,000 bookmarks

Created on 3 Oct 2020  路  5Comments  路  Source: nextcloud/bookmarks

NextcloudPi 19.0.3 with Bookmarks 3.4.1

Describe the bug

  1. Select a bookmark.
  2. Select All
  3. Browser will hang for over a minute on Firefox 81 (64-bit) on an i5 with 8gb of ram.
    image
  4. 1,342 bookmarks selected.
    image
bug

All 5 comments

Moving selections should become faster now. However, selecting a large amount of bookmarks is still slow.

Confirmed, it is faster to select in 3.4.4 Still got browser timeout when selecting 980 bookmarks, but process was much faster at about 15 seconds to select all from Firefox 81 64-bit with 8gb ram and i5 processor. :+1:

Is there a warning when so many bookmarks are copied. At a maximum of 500 hundred or so, to prevent issues when copying.
Add an overwrite to warning, so the user can neglect the maximum limit.

There is currently no warning. Copying 500 items should work quite well, as it only copies 10 items at max in parallel.

The problem is selecting all bookmarks, which needs to first download them all, but likely neither the network nor the backend are the bottleneck, but the render process in the browser which currently renders all 980 bookmarks.

Note to self: A virtual list may be the way to go here (https://github.com/Mikescops/vue-virtual-grid seems useful)

Copying 500 items is no issue for me at all. Also, performance has notably increased in general since this post was originally created. Just tested in 20.0.8 stable from a low spec Odroid C2:

_Select All_ 1,600 bookmarks from current Firefox stable took 19 seconds and gave a "stop or wait" warning before completing. Big improvement!!!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

homelessgamer picture homelessgamer  路  6Comments

marcelklehr picture marcelklehr  路  4Comments

kaffeeringe picture kaffeeringe  路  6Comments

lyallp picture lyallp  路  4Comments

ifuchs picture ifuchs  路  4Comments