Bforartists: 3D View - Transform panel change 4L button icon

[iyadahmed]

the button looks same, pressed or not
either change icon, or enable emboss

[ReinerBforartists]

There is no icon here, this is pure text. And it is C code from what i see. So the first quesiton is, color the text or insert an icon? Emboss seems to be the easier method. A real button the cleaner one.

[iyadahmed]

I see, I just tried embossing, and it colors the text green if it is not pressed, and white if it was

I think we can just use the lock icon, because this controls the lock_rotations_4d property, so it would be consistent with others

[ReinerBforartists]

Your task, decide what fits better :)

The lock icon could be misleading here though. How turned out the text color?

[iyadahmed]

it was ok, but as you said a real button is better, I guess embossing is the way to go then if lock icon is misleading

[iyadahmed]

but actually the text isn't better it is as misleading, a lock is better on the other hand, and the tooltip is always there

EDIT: still not sure will decide later, when I get to this task

[ReinerBforartists]

Welcome to UI design. It will not become easier later :D

[iyadahmed]

indeed :D XD

[ReinerBforartists]

What speaks for the text is that Blender has handled it that way. Former Blender user will know and recognize what it is.

When unsure leave it as is. A change for the sake of a change is not good.

[iyadahmed]

I agree, I thought so, decided on text

[iyadahmed]

will postpone for now, may reopen again, using text isn't perfect, can't keep fixed size when resizing, but with a icon only it can be, so ideally we would create an icon for 4L, the icon would an image of the text 4L, when the property is fasle the text has a red mark

[ReinerBforartists]

Related: https://github.com/Bforartists/Bforartists/issues/1943

When we know what the button is good for then we can decide what icon to shape.

[iyadahmed]

agree

[ReinerBforartists]

New icon is in progress.

[iyadahmed]

New icon is in progress.

Awesome

[ReinerBforartists]

Icons are added. And committed to the master.

Name of the icons : 4L_ON and 4L_OFF

Pink background comes from the icon sheet. Is transparent.

[iyadahmed]

great editing the prop icon now

[iyadahmed]

looking great

[ReinerBforartists]

Much better than the previous version. And now you can really say what state is on and what is off :)

[iyadahmed]

Indeed, much better after this change :)

On Sun, 1 Nov 2020 at 12:14 PM ReinerBforartists [e-mail]
wrote:

Much better than the previous version. And now you can really say what
state is on and what is off :)

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Bforartists/Bforartists/issues/1937#issuecomment-720064246,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGC6KLOIHJAWZXWT2SC3CQ3SNUYIBANCNFSM4TCTWSOQ
.