Bentobox: Cannot add island, upgrade 0.14.0->0.14.1

[SlimeDog]

Description

[06:48:52] [Server thread/INFO]: Could not set generator for world 'world_skyblock': Plugin 'BentoBox v0.14.1' is not enabled^[[m
[06:48:53] [Server thread/INFO]: Could not set generator for world 'world_skyblock': Plugin 'BentoBox v0.14.1' is not enabled^[[m

and

[06:37:47] [Server thread/ERROR]: [BentoBox] Cannot add island to grid because there is an overlapping
[06:37:47] [Server thread/ERROR]: [BentoBox] island already registered at this location:Location{world=CraftWorld{name=world_skyblock},x=0.5,y=120.0,z=0.5,pitch=0.0,yaw=0.0}
[06:37:47] [Server thread/ERROR]: [BentoBox] This is most likely caused by island distances changing mid-game, or an old database file

Steps to reproduce the behavior:

1. Stop server.
2. Update locales/BentoBox/en-US.yml to include COARSE_DIRT_TILLING content.
3. Replace bentobox-0.14.0.jar with bentobox-0.14.1.jar
4. Start server
5. Observer errors in console/log
6. Stop and restart server
7. Observer errors in console/log

Note that island exists, and can be visited.

Expected behavior
A clear and concise description of what you expected to happen.

Server Information:

• Database being used (Flat file, MySQL, Mongo): Flat
• OS: CentOS Linux
• Java Version:

openjdk version "1.8.0_181"
OpenJDK Runtime Environment (build 1.8.0_181-b13)
OpenJDK 64-Bit Server VM (build 25.181-b13, mixed mode)

• BentoBox version and addons:

[06:41:32 INFO]: Bentobox version: 0.14.1
[06:41:32 INFO]: Loaded Game Worlds:
[06:41:32 INFO]: world_skyblock (BSkyBlock)
[06:41:32 INFO]: Loaded Add-Ons
[06:41:32 INFO]: BSkyBlock 0.5.0-SNAPSHOT
[06:41:32 INFO]: BentoBox-Challenges 0.0.3-SNAPSHOT
[06:41:32 INFO]: Level 0.1.0-SNAPSHOT

Console/log

[06:48:40] [Server thread/INFO]: [BentoBox] Loading BentoBox v0.14.1
[06:48:52] [Server thread/INFO]: Could not set generator for world 'world_skyblock': Plugin 'BentoBox v0.14.1' is not enabled^[[m
[06:48:53] [Server thread/INFO]: Could not set generator for world 'world_skyblock': Plugin 'BentoBox v0.14.1' is not enabled^[[m
[06:49:02] [Server thread/INFO]: [BentoBox] Enabling BentoBox v0.14.1
[06:49:02] [Server thread/INFO]: [BentoBox] Loading addons...
[06:49:02] [Server thread/INFO]: [BentoBox] Loading island.schem for world_skyblock
[06:49:02] [Server thread/INFO]: [BentoBox] Loading nether-island.schem for world_skyblock_nether
[06:49:02] [Server thread/INFO]: [BentoBox] Loading end-island.schem for world_skyblock_the_end
[06:49:02] [Server thread/INFO]: [BentoBox] Loaded 3 addons.
[06:49:02] [Server thread/INFO]: [BentoBox] Enabling addons...
[06:49:02] [Server thread/INFO]: [BentoBox] Enabling BSkyBlock...
[06:49:02] [Server thread/INFO]: [BentoBox] Loading challenges...
[06:49:02] [Server thread/INFO]: [BentoBox] Enabling BentoBox-Challenges...
[06:49:02] [Server thread/INFO]: [BentoBox] Enabling Level...
[06:49:02] [Server thread/INFO]: [BentoBox] Addons successfully enabled.
[06:49:23] [Server thread/INFO]: [BentoBox] Added world SkyBlock (HARD)
[06:49:23] [Server thread/ERROR]: [BentoBox] Cannot add island to grid because there is an overlapping
[06:49:23] [Server thread/ERROR]: [BentoBox] island already registered at this location:Location{world=CraftWorld{name=world_skyblock},x=0.5,y=120.0,z=0.5,pitch=0.0,yaw=0.0}
[06:49:23] [Server thread/ERROR]: [BentoBox] This is most likely caused by island distances changing mid-game, or an old database file
[06:49:23] [Server thread/INFO]: [BentoBox] Hooking with Vault...
[06:49:23] [Server thread/INFO]: [BentoBox] Hooking with PlaceholderAPI...
[06:49:23] [Server thread/INFO]: [BentoBox] Hooking with Multiverse-Core...
[06:49:23] [Server thread/INFO]: ^[[0;32;1mSuccess!^[[0;37;1m Property ^[[0;36;1mgenerator^[[0;37;1m was set to ^[[0;32;1mBentoBox^[[m
[06:49:23] [Server thread/INFO]: [BentoBox] #############################################
[06:49:23] [Server thread/INFO]: [BentoBox] BentoBox v0.14.1 has been fully enabled.
[06:49:23] [Server thread/INFO]: [BentoBox] It took: 21505ms
[06:49:23] [Server thread/INFO]: [BentoBox] Thanks for using our plugin !
[06:49:23] [Server thread/INFO]: [BentoBox] - Tastybento and Poslovitch, 2017-2018
[06:49:23] [Server thread/INFO]: [BentoBox] #############################################

[tastybento]

The generator error is definitely a concern.

The other error - I haven’t finished working on that yet. I’ll use this ticket to track it through.

[SlimeDog]

This is a test server, so I am free to experiment. Is there anything specific you would like me to try? Different scenarios?

[tastybento]

Any other plugins? Do you see the problem with a fresh install? Make a few islands, then restart etc.

[SlimeDog]

80+ plugins, same as with BB 0.14.0.

Test 1:

• Remove database, leaving BB+addons+configuration.
• Restart server.
• No console/log errors.
• Of course, also no island.

Test 2:

• Replace database.
• ls plugins/BentoBox/database/Island/

03513fae-90a7-4ae8-aba3-f4b04a69e641.yml
0d6b9b3c-a0a1-49f2-9cd4-a0d3141d3c64.yml
1d161cb1-5421-4cb9-877a-7fc3c4f67c29.yml

• grep owner: plugins/BentoBox/database/Island/*

plugins/BentoBox/database/Island/03513fae-90a7-4ae8-aba3-f4b04a69e641.yml:owner: 'null'
plugins/BentoBox/database/Island/0d6b9b3c-a0a1-49f2-9cd4-a0d3141d3c64.yml:owner: PLAYER_UUID
plugins/BentoBox/database/Island/1d161cb1-5421-4cb9-877a-7fc3c4f67c29.yml:owner: PLAYER_UUID

• Remove plugins/BentoBox/database/Island/03513fae-90a7-4ae8-aba3-f4b04a69e641.yml
• Restart server.
• No console/log errors.
• Player island appears intact.
• diff plugins/BentoBox/database/Island//*

1,2c1,2
< uniqueId: 0d6b9b3c-a0a1-49f2-9cd4-a0d3141d3c64
< center: world_skyblock:0:120:0:0:0
---
> uniqueId: 1d161cb1-5421-4cb9-877a-7fc3c4f67c29
> center: world_skyblock:0:120:256:0:0
7,8c7,8
< createdDate: 1535646276301
< updatedDate: 1535646276301
---
> createdDate: 1535867422121
> updatedDate: 1535867422121
68,70c68,70
<   NETHER: world_skyblock_nether:-2:125:0:1135132672:1106247680
<   THE_END: world_skyblock_the_end:-1:126:-1:1134395392:1106247680
<   NORMAL: world_skyblock:0:125:2:0:1106247680
---
>   NETHER: world_skyblock_nether:-2:125:256:1135132672:1106247680
>   THE_END: world_skyblock_the_end:-1:126:255:1134395392:1106247680
>   NORMAL: world_skyblock:0:125:258:0:1106247680

• Both islands are owned by _PLAYER_UUID_. One is legitimate. The other is a never-used island. In both directions, when I travel between them with /tp

Now leaving _PLAYER's_ island
Now entering _PLAYER's_ island

Test 3:

• Remove second (unused) player island.
• Restart server.
• No console/log errors.
• Player island appears intact.
• Second island real estate exists.
• bsb info at second island

You are not in an island right now...

I assume that it is safe to remove the real estate.

NOTE: Real player name replaced with _PLAYER_, and real player UUID replace with _PLAYER_UUID_.

[tastybento]

Yes, it looks like there was a duplicate island so the error in the console was actually correct. Let's keep an eye on this but I'll close it for now. Thanks for the info.

[SlimeDog]

How do you think the duplicate island was created? With the same owner? And the other island entry, that didn't physically exist? It had the same center as my real island.

[Poslovitch]

The cause will probably remain unknown, but isn't there a way we could "fix" this @tastybento ? I was thinking of removing the "invalid duplicate" island automatically

[SlimeDog]

What is the stair island?

[Poslovitch]

@SlimeDog Sorry, edited my comment above. I was writing the comment while going to a lesson, so I did make a few mistake.