Bentobox: Errors spamming in console when player enters normal Nether and The End

[AngieC233]

Errors spamming in console when players enter the normal Nether and The End. It is fine, when they enter BSkyblock Nether and BSkyblock The End.

Server Information:

• Database being used: Flat file

  • Using Spigot version CraftBukkit version git-Spigot-eb21557-4a47be6 (MC: 1.13.2) (Implementing API version 1.13.2-R0.1-SNAPSHOT).
• Java Version: Java 8

Plugins :
AutoGamemode, BlockThatName, PluginConstructorAPI, BlockLocker, VoidWorld, TeleportRequest, Lift, TuxTwoLib, LongerTimev1, SkinsRestorer, PermissionsBukkit, PrefixManager, mcMMOHorse, CoreProtect, dynmap, RealPing, Spectate, XRayDetector, PacketListenerApi, WorldBorder, Votifier, ProtocolLib, dynmap-mobs, VotingPlugin, AsyncWorldEdit, NoSpawnChunks, MCGUIControlPluginFreeVersion, BentoBox, BlocksHub, mcMMO, Vault, Gmlist, MassiveCore, PerWorldInventory, CreativeGates, HolographicDisplays, VillageDefense, MassiveBooks, WorldEdit, MassiveHat, Orebfuscator4, Essentials, Citizens, EssentialsChat, Vampire, Dynmap-Citizens2, PlotSquared, WorldGuard, Factions, EssentialsProtect, EssentialsGeoIP, EssentialsAntiBuild, EssentialsSpawn, Jobs, ScoreboardStats, Multiverse-Core, Sentinel, DiscordSRV, Residence, GriefPrevention, ChestShop, AuthMe, MobArena, Jail, MultiWorldMoney

• BentoBox version: Was using v0.10.1-alpha1 and then upgraded to v.11.1-alpha1

• Addons installed:
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] Bentobox version: 0.11.0-alpha1
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] Loaded Game Worlds:
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] BSkyBlock_world (BSkyBlock)
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] Loaded Add-Ons
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] BSkyBlock 0.4.0-SNAPSHOT
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] BentoBox-Level 0.0.2-SNAPSHOT
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] BentoBox-WelcomeWarps 0.0.4-SNAPSHOT
  [Sat, 27. Oct 2018 12:32:28 UTC INFO] BentoBox-Challenges 0.0.3-SNAPSHOT

Additional context
Same issues when we use MC 1.13.1 before upgrading to MC 1.13.2

Errors in console when using BentoBox v0.10.1-alpha1
https://pastebin.com/X5PumAU0

Errors when using BentoBox v0.11.1-alpha1
https://pastebin.com/T6xzwkqc

[Poslovitch]

Thanks for your bug report.
However, both stacktraces are the same (same link). Can you fix that please?

[AngieC233]

Thank you for the quick response. Sorry didn't realised it was the same. Fixed the link above

[Poslovitch]

Thanks, I'll investigate that.

[Poslovitch]

The first link does not contain useful stacktrace information. Let me suggest you to read that so you can help us better next time : https://www.spigotmc.org/wiki/fixing-plugin-problems-easily-reading-stacktraces/. ;)

Anyway, I can try to figure out what's going on using the second link.

[Poslovitch]

Okay, so we've got two interesting things there :

1. NPE on PlayerTeleportEvent:

Caused by: java.lang.NullPointerException
at world.bentobox.bentobox.managers.IslandWorldManager.isEndGenerate(IslandWorldManager.java:279) ~[?:?]
at world.bentobox.bentobox.managers.IslandsManager.getIslandAt(IslandsManager.java:300) ~[?:?]
at world.bentobox.bentobox.managers.IslandsManager.getProtectedIslandAt(IslandsManager.java:355) ~[?:?]
at world.bentobox.bentobox.listeners.flags.LockAndBanListener.check(LockAndBanListener.java:102) ~[?:?]
at world.bentobox.bentobox.listeners.flags.LockAndBanListener.checkAndNotify(LockAndBanListener.java:121) ~[?:?]
at world.bentobox.bentobox.listeners.flags.LockAndBanListener.onPlayerTeleport(LockAndBanListener.java:40) ~[?:?]

1. NPE on PlayerMoveEvent:

Caused by: java.lang.NullPointerException
at world.bentobox.bentobox.managers.IslandWorldManager.isEndGenerate(IslandWorldManager.java:279) ~[?:?]
at world.bentobox.bentobox.managers.IslandsManager.getIslandAt(IslandsManager.java:300) ~[?:?]
at world.bentobox.bentobox.managers.IslandsManager.getProtectedIslandAt(IslandsManager.java:355) ~[?:?]
at world.bentobox.bentobox.listeners.flags.LockAndBanListener.check(LockAndBanListener.java:102) ~[?:?]
at world.bentobox.bentobox.listeners.flags.LockAndBanListener.checkAndNotify(LockAndBanListener.java:121) ~[?:?]
at world.bentobox.bentobox.listeners.flags.LockAndBanListener.onPlayerMove(LockAndBanListener.java:50) ~[?:?]

And we've also got a nice error just before:

[08:40:33] [Server thread/INFO]: Scanning for legacy world dragon fight...
[08:40:33] [Server thread/INFO]: Found that the dragon has been killed in this world already.

Whose stacktrace is:

[08:40:29] [Server thread/ERROR]: Could not pass event PlayerTeleportEvent to BentoBox v0.10.1-alpha1
Caused by: java.lang.NullPointerException
at world.bentobox.bentobox.managers.IslandWorldManager.isEndGenerate(IslandWorldManager.java:279) ~[?:?]
at world.bentobox.bentobox.managers.IslandsManager.getIslandAt(IslandsManager.java:300) ~[?:?]
at world.bentobox.bentobox.managers.IslandsManager.locationIsOnIsland(IslandsManager.java:631) ~[?:?]
at world.bentobox.bentobox.listeners.flags.RemoveMobsListener.onUserTeleport(RemoveMobsListener.java:23) ~[?:?]

That's definitely an interesting one!

[AngieC233]

These are the errors when using BentoBox v0.11.1-alpha1, the errors will spam the console as long as the player is in the normal Nether or normal The End
https://pastebin.com/z2UKiT2k

[Poslovitch]

Confirmed that the bug is still occuring on 0.14.0-SNAPSHOT.
It seems to be related to the way Worlds are handled in the IslandWorldManager; it's going to be a tough bug to fix.