Bat: AsciiDoc: Consider switching to a different dependency for syntax highlighting

Created on 8 Oct 2020  路  5Comments  路  Source: sharkdp/bat

The repository which is used for syntax highlighting of AsciiDoc seems to be unmaintained (see asciidoctor/sublimetext-asciidoc). There are issues and PRs unresolved / unanswered for 4 years and longer.

There is a minor issue with the syntax highlighting that was found while implementing AsciiDoc tests in PR #1229. The bug has been reported to the library mentioned above, but probably won't get fixed.

Consider switching to a different dependency for AsciiDoc syntax highlighting. Here are some more up-to-date libraries I've found that have AsciiDoc highlighting, but I don't know whether they could be used inside bat or not, as they are mostly JS libraries:

Edit
There actually are already some forks that are more up-to-date than the original repo, but I don't know if those are just forks meant for personal use or if they are trying to continue the project.

This issue doesn't need immediate attention. I just created it to make sure its in the backlog.

Most helpful comment

Update

I just commented on an issue in the original repository and asked both people that are maintaining the forks if any of them would be willing to continue the project on their fork.

Hopefully we'll hear back from them. :)

All 5 comments

It is much easier to just make a PR to the original repo than rewrite one of given plugins to .tmTheme file

It is much easier to just make a PR to the original repo than rewrite one of given plugins to .tmTheme file

I agree, but as I've said in my post: The repository seems unmaintained and therefore very unlikely to accept a PR.
There are three open PRs from 2016 / 2017 and no closed ones, meaning there never even was a PR that made it into master.

image

Then it's possible to make a fork and switch bat to using it. Unmaitenance is bad, but you're not forced to use the original repo. There are some popular projects that started as a fork, e.g. picom

Then it's possible to make a fork and switch bat to using it. Unmaitenance is bad, but you're not forced to use the original repo.

Correct, but as sharkdp already pointed out in a comment on the PR #1229, he doesn't like to maintain such a fork himself, and neither do I, as I'm not familiar with the project.

I've already updated my initial post and mentioned existing forks of the repository that seem to be more up-to-date, maybe you missed that. But neither of them made any statement in the README about if those are just personal forks or if they are actively trying to maintain a stable continuation of the project.

Update

I just commented on an issue in the original repository and asked both people that are maintaining the forks if any of them would be willing to continue the project on their fork.

Hopefully we'll hear back from them. :)

Was this page helpful?
0 / 5 - 0 ratings