Azuredatastudio: Functions being wrapped in Brackets

[LarnuUK]

Issue Type: Bug

When typing functions native to SQL Server (I haven't tested with User Scalar functions, as I don't tend to use them) and using Tab to complete the name, the function is being wrapped in Brackets ([]), instead of having parentheses (()) added at the end and the cursor being put inside them.

Wrapping them in Brackets invalidates the function, as it would mean it is treated as an object name, not a function.

You can see this in the below animated image:

Edit: Note this was not a "feature" (bug) on previous versions of ADS. I did have ADS 1.8 installed on Windows, however, as a test I updated it to 1.12.1 (released yesterday at time of edit) 1.12.0 and it now too has the above "feature".

Azure Data Studio version: azuredatastudio 1.10.0 (5fdb967ffcea41df0335ec17cfa396a694bb174e, 2019-08-14T18:03:49.463Z)
OS version: Linux x64 5.0.0-31-generic

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 4299)|
|GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled|
|Load (avg)|2, 1, 1|
|Memory (System)|15.58GB (6.42GB free)|
|Process Argv|--unity-launch|
|Screen Reader|no|
|VM|0%|

Extensions (7)

Extension|Author (truncated)|Version
---|---|---
vsc-material-theme|Equ|30.0.0
admin-pack|Mic|0.0.2
agent|Mic|0.43.0
dacpac|Mic|0.6.0
profiler|Mic|0.9.0
material-icon-theme|PKi|3.9.0
sql-search|Red|0.3.4

[LarnuUK]

Seems to have no been fixed in 1.12.1 (I had installed 1.12.0 when I made the above edit, not 1.12.1)

[LarnuUK]

I'm reopening this issue, as it appears to be intermittent, and I am getting the behaviour in 1.12.1.

[kburtram]

@LarnuUK I haven't seen this before. Do you happen to have any extensions, such as Postgres, installed? Or any customized editor settings?

[LarnuUK]

Hi @kburtram , all the extensions installed are listed in my original post, which I believe are the same both on Ubuntu and Windows (as I have experienced the "feature" on both environments). PostgreSQL isn't one of those though.

[dimitri-b]

I have the same issue in 1.13.0

I have 3 extentions:

Extension|Author (truncated)|Version
---|---|---
import|Mic|0.12.0
azdata-sanddance|msr|1.3.9
poor-sql-formatter|WSR|0.1.0