Azuredatastudio: Unable to open file browser

[Skydyvyr]

Issue Type: Bug

I'm running a Mac with the latest O/S. When I attempt to brows to a backup file (stored locally), I get the following error:

An error occured while loading the file browser.

Hand entering the path into the field doesn't work either.

Azure Data Studio version: Azure Data Studio 1.5.2 (f74080c96310354bc92211f1826c0fdce78ca2f6, 2019-03-22T06:09:10.602Z)
OS version: Darwin x64 18.5.0

System Info

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz (4 x 2700)|
|GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled|
|Load (avg)|3, 4, 4|
|Memory (System)|8.00GB (0.04GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|

Extensions: none

[Skydyvyr]

[kburtram]

@udeeshagautam according to @shueybubbles SSMS is mitigating this issue by setting the initial remote directory using the SMO Server.BackupDirectory property. Which apparently is still enumerable properly with sys.dm_os_enumerate_filesystem on non-Windows platforms. This may be a reasonable workaround for ADS as well.

[udeeshagautam]

@kburtram @shueybubbles, we do currently check Server.BackupDirectory but use it only to expand the tree not populate (because we want to populate the tree from root). Should we use Server.BackupDirectory to populate the tree only when root folders are incorrect or in all cases? suggestions?

[shueybubbles]

There are a few places in SSMS that have this same problem; only one part of the SSMS experience handles this failure semi-gracefully by only populating the folder list with the default folder.
Can ADS handle the failure to populate from the root by re-rooting the tree at the default directory?

[udeeshagautam]

Ah yes the above is good example.
I think yes, we can change sqltoolsservice to behave that way. Will try the change and send a PR for this.