Atrium: CharSequence.matches

[robstoll]

Platform (jvm, jdk8, js, android): all

Code related feature

expect("hello").matches(Regex("([hH]ello"))

which should result in reporting

expect: "hello World"       (String<987383>)
* matches entirely: [hH]ello     (Regex<123423>)

This assertion function matches the entire CharSequence in contrast to expect("hello").containsRegex(...), ergo it fails if it contains a match only within the CharSequence.

Following the things you need to do:

domain

• extend CharSequenceAssertions with a function matches which expects a Regex (see other functions as a guideline but use Expect instead of SubjectProvider)
• modify CharSequenceAssertionsBuilder, delegate to charSequenceAssertions (see other functions as a guideline)
• delegate implementation to robstoll-lib in CharSequenceAssertionsImpl (see other functions as a guideline)

lib

• implement _matches in charSequenceAssertions
  
  
  
  • add MATCHES("matches entirely") to DescriptionCharSequenceAssertion for en_GB
  
  
  • add MATCHES("stimmt vollständig überein mit") to DescriptionCharSequenceAssertion for de_CH
  
  

api (only fluent-en_GB)

• provide the fun matches (see other assertion functions in charSequenceAssertions.kt)
• extend CharSequenceAssertionsSpec in specs-common (see for instance YzFeatureAssertionsSpec) and extend it in atrium-api-fluent-en_GB-common/src/test
  
  
  
  • include a test case where there is a match within the CharSequence
  
  

Your first contribution?

• Write a comment I'll work on this if you would like to take this issue over.
  This way we get the chance to revise the description in case things have changed in the meantime,
  we might give you additional hints and we can assign the task to you, so that others do not start as well.
• See Your first code contribution for guidelines.
• Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
  (Invite yourself in case you do not have an account yet).

[mikemolenda]

I'll work on this

[robstoll]

@mikemolenda in case you already started with the implementation. I have removed the overload which expects only a String. I am not yet 100% sure if it is a good idea to add it. Let's start with Regex only