Platform (jvm, js, android): jvm
Extension (none, kotlin 1.3, jdk8): none
We currently provide an example-pom.xml and a settings.xml for maven.
It would be nicer if we actually have a full-working sample for maven.
Following the things you need to do:
I'll work on this if you would like to take this issue over.@binkley I saw that you are using Atrium in a maven context (https://github.com/binkley/spikes/blob/master/scratch/pom.xml). Would you mind creating a sample project so that others have an easier start when using Atrium as well? (and let me know if there are things which need to be improved for maven)
@robstoll I'd love to! <3
What model should I follow? Any specific kinds of tests, etc.?
nice :+1: the idea is to have a minimalistic setup of a maven project using Atrium and some test-runner (e.g. junit + jupiter) including a SampleTest. So that someone wanting to start out a new project and would like to use Atrium can basically copy the sample project.
You can come up with a SampleTest or copy an existing one (e.g. samples/jvm/junit5/src/test/kotlin/org/atriumlib/samples/junit5/SampleJvmTest.kt)
The sample looks good. The only change I'd like to make: I've run into the Kotlin convention of providing "text" test method names, ie:
fun `expect an exception occurred`() { ... }
rather than:
fun expectAnExceptionOccurred() { ... }
good idea, I forgot about that for JUnit. Good with me, you can also change it in the other samples if you like.
PR updated to separate Gradle and Maven builds.