Atrium: ChronoLocalDate(Time) and ChronoZonedDateTime.isAfter

[robstoll]

Platform (jvm, js, android): jvm
Extension (none, kotlin 1.3, jdk8): jdk8

Code related feature

expect(LocalDate.now().plusDays(1)).isAfter(LocalDate.now())

Following the things you need to do (same same but different for ChronoLocalDateTime<D> and ChronoZonedDateTime<D> with D: ChronoLocalDate):

domain-lib

• create chronoLocalDateAssertions.kt (in the same folder as localDateAssertions.kt) and implement _isAfter in it by using the ExpectImpl.builder.createDescriptive(... (see comparableAssertions.kt)
  
  
  
  • add IS_AFTER("is after") to DescriptionDateTimeLikeAssertion for en_GB
  
  
  • add IS_AFTER("ist nach dem") to DescriptionDateTimeLikeAssertion for de_CH
  
  

domain

• create ChronoLocalDateAssertions with a function isAfter (see LocalDateAssertions as a guideline)
• create ChronoLocalDateAssertionsBuilder, delegate to chronoLocalDateAssertions (see LocalDateAssertionsBuilder as a guideline)
• create ChronoLocalDateAssertionsImpl and delegate implementation to robstoll-lib (see other functions as a guideline)
  
  
  
  • register ChronoLocalDateAssertions as new service in /domain/robstoll/atrium-domain-robstoll-jvm/src/main/resources/META-INF/services (see LocalDateAssertions as a guideline)
  
  
  • exclude it for JS in /build.gradle (search for createRegisterJsServicesTask)
  
  

api

• provide a fun isAfter which expects a ChronoLocalDate (see localDateAssertions as guideline)
• add @since 0.9.0 (adopt to next release version) to KDOC of val and fun
• cover new functionality in ChronoLocalDateAssertionsSpec in specs-jvm and extend it in atrium-api-fluent-en_GB-common/src/test

Your first contribution?

• Write a comment I'll work on this if you would like to take this issue over.
  This way we get the chance to revise the description in case things have changed in the meantime,
  we might give you additional hints and we can assign the task to you, so that others do not start as well.
• See Your first code contribution for guidelines.
• Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
  (Invite yourself in case you do not have an account yet).

[ivanmiklec]

I'll work on this

[ivanmiklec]

Hey, just wanted to give you an update, I was kinda busy so I started working on this yesterday

[robstoll]

@name213 do you need any help?

[ivanmiklec]

@robstoll hey thanks for offering help, I will push my WIP today or tomorrow

[robstoll]

implemented with f0f0e3e