Atrium: bigDecimalAssertions for the new infix API

Created on 18 Oct 2019  路  6Comments  路  Source: robstoll/atrium

Platform (jvm, js, android): jvm
Extension (none, kotlin 1.3, jdk8): none

Code related feature

We want to migrate the api-cc-infix-en_GB... modules which are based on Assert to Expect. We have already created the corresponding
modules api-infix-en_GB.... Also there are already fluent-en_GB... modules where we have already done the transition from Assert to Expect

Following the things you need to do:

  • copy the file bigDecimalAssertions.kt from atrium-api-fluent-en_GB-jvm to atrium-api-infix-en_GB-jvm

    • adjust the signatures of the assertion functions so that they are infix functions (see bigDecimalAssertions.kt in atrium-api-cc-infix-en_GB-jvm for a guideline)

    • change since 0.9.0 to 0.11.0

  • copy the BigDecimalAssertionsSpec.kt from atrium-api-fluent-en_GB-jvm to atrium-api-infix-en_GB-jvm

    • introduce a function in the companion object for each assertion function so that we see the infix API in action (see BigDecimalAssertionsSpec in atrium-api-cc-infix-en_GB-jvm but use fun1, fun2 etc. to retrieve the name of the function instead of KFunction<...> -- use fun1<..>(...).name)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
good first issue help wanted

All 6 comments

I'll work on this

@sneha122 do you need help? Un-assigning so that others can take over

I'll work on this

@afurtak do you need help? un-assigning you so that others can take over

I'll work on this

@isfedorov nice that you tackle that many issues :slightly_smiling_face: :+1:
I have sent you an invitation to be part of the contributors. This way you can assign tasks yourself.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  5Comments

robstoll picture robstoll  路  7Comments

robstoll picture robstoll  路  6Comments

robstoll picture robstoll  路  4Comments