Issue Documentation is http://handbook.arctosdb.org/how_to/How-to-Use-Issues-in-Arctos.html
Table
http://arctos.database.museum/info/ctDocumentation.cfm?table=CTSPECPART_ATTRIBUTE_TYPE
Proposed new values
anatomical direction reference
tooth order
tooth set
tooth abbreviation
Definition
Attribute | Definition
-- | --
anatomical direction reference |
tooth order | Used for mammals, the numerical order of the tooth from anterior to posterior counting from the first tooth of the same type (ex. molar 1, molar 2, molar 3).
tooth set | for diphyodont mammals - deciduous (milk/baby teeth) or permanent
tooth abbreviation | abbreviation used to describe mammal teeth, typically in paleontology
Collection type
N/A
Attribute data type
Attribute | Allowed values
-- | --
anatomical direction reference | categorical
tooth order | categorical
tooth set | categorical
tooth abbreviation | free-text
Attribute value
Attribute | Controlled Values
-- | --
anatomical direction reference | left, right, upper, lower, dorsal, ventral, lateral, medial, caudal, cranial, proximal, distal, superficial, deep
tooth order | 1, 2, 3, 4
tooth set | deciduous, permanent
Attribute units
N/A
Part tissue flag
N/A
Other ID BaseURL
N/A
Context
Paleo specimens are often a single bone or tooth with information such as to which side of the body the bone belongs or to which jaw the tooth belongs. Teeth are numbered according to their placement in the jaw and may also be deciduous or permanent. We would like to add these part attributes and associated controlled vocabularies to allow for more refined searching of paleo specimens.
Priority
Please assign a priority-label.
Attribute value definitions (need to research a few):
@mvzhuang do you have any thoughts on this? I think I may email to Art for his opinion too.
The one that has been bothering me is left/right. I think we should call this "anatomical directional reference" which would also allow use of the following terms in the controlled vocabulary for the value: dorsal, ventral, frontal, proximal, and distal (see Wikipedia)
The one that has been bothering me is left/right. I think we should call this "anatomical directional reference" which would also allow use of the following terms in the controlled vocabulary for the value: dorsal, ventral, frontal, proximal, and distal (see Wikipedia)
@Nicole-Ridgwell-NMMNHS as I work on parts for locality 1, there are a lot of "dorsal", "distal", etc. and I'd like to decide if we want these in attributes or just thrown in part remarks. What do you think?
Also wonder if "upper" and "lower" should also be part of "anatomical direction reference"?
I'd like to decide if we want these in attributes or just thrown in part remarks.
I think putting that in part remarks and broadening left/right to anatomical direction reference is a great idea.
Couldn't we have left, right, dorsal, distal etc all be values in a single
attribute of anatomical directional reference? That is what you are
proposing, correct? So why the need for putting anything in part remarks?
Why not have a code table of values, and be allowed to use the attribute
more than once for, say, "distal" and "right" e.g. femur?
On Thu, Oct 31, 2019 at 1:30 PM Nicole-Ridgwell-NMMNHS <
[email protected]> wrote:
I'd like to decide if we want these in attributes or just thrown in part
remarks.I think putting that in part remarks and broadening left/right to
anatomical direction reference is a great idea.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/2330?email_source=notifications&email_token=ADQ7JBF4GXRUD5PLTDR3JKDQRMW6LA5CNFSM4JEMYJY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECY7LZQ#issuecomment-548533734,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBBN6PLIFJLGAML5G2LQRMW6LANCNFSM4JEMYJYQ
.
Sorry, mistyped. meant to say putting in attributes is a great idea.
OK, that sounds like a good idea then!
On Thu, Oct 31, 2019 at 1:34 PM Nicole-Ridgwell-NMMNHS <
[email protected]> wrote:
Sorry, mistyped. meant to say putting in attributes is a great idea.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/2330?email_source=notifications&email_token=ADQ7JBG4YPMDY4PBVRZZI2DQRMXNTA5CNFSM4JEMYJY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECY7WPY#issuecomment-548535103,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBE7XZHKQOAZNY4HQHTQRMXNTANCNFSM4JEMYJYQ
.
It's worth mentioning that PART_ATTRIBUTES cannot be added from Data Entry (only via bulkloading), so it would be good to add this capability
PART_ATTRIBUTES cannot be added from Data Entry (only via bulkloading)
Yes but no...
You can add them from data entry ("add more"), but it's currently a separate process to load them. (It's just a click or two and Arctos will send email, but it's still separate.) https://github.com/ArctosDB/arctos/issues/2178 might change that.
Instead of tooth order, recommend "numeric order" for use in multiple areas where things are given an order in a series.
@dustymc AWG has agreed to the addition of these part attributes. I need to set up the controlled vocab for anatomical direction reference, which means I need a new code table. Suggest CTANATOMICAL_DIRECTION with the following terms/definitions to start.
Also, for "numeric order" can we limit this to integers?
Can it wait for postgres? I don't think there's a lot of risk of directly breaking the DB, other than time catching up to us, but it requires a fair bit of code and almost none of it's directly cross-platform. Can you use this as free-text for the (very, I hope) immediate future and clean up as necessary in PG?
numeric order
Add to http://arctos.database.museum/info/ctDocumentation.cfm?table=CTCOUNT_UNITS - like http://arctos.database.museum/info/ctDocumentation.cfm?table=CTATTRIBUTE_CODE_TABLES&field=numeric%20abundance
Can it wait for postgres? I don't think there's a lot of risk of directly breaking the DB, other than time catching up to us, but it requires a fair bit of code and almost none of it's directly cross-platform. Can you use this as free-text for the (very, I hope) immediate future and clean up as necessary in PG?
We can certainly free-text this for now and our stuff should be fairly clean, but I can't speak for anyone else who discovers and starts using it!
Let's do this https://github.com/ArctosDB/arctos/issues/2330#issuecomment-554761641
Involves setting up tables for controlled vocabs and ensuring that currently used terms comply.
@Jegelewicz
tooth set - seems like a boolean (eg is [not] adult) - can that be phrased to use https://arctos.database.museum/info/ctDocumentation.cfm?table=ctyes_no?
https://arctos.database.museum/info/ctDocumentation.cfm?table=ctcount_units should work for the rest
What'd I miss?
See https://github.com/ArctosDB/arctos/issues/2354
tooth set - seems like a boolean (eg is [not] adult) - can that be phrased to use https://arctos.database.museum/info/ctDocumentation.cfm?table=ctyes_no?
Maybe? is there anything other than deciduous and adult? @Nicole-Ridgwell-NMMNHS
Edited https://github.com/ArctosDB/arctos/issues/2330#issuecomment-660181579
Maybe? is there anything other than deciduous and adult?
Not for mammals, which is what we are really talking about here since I don't think there are any other groups where you can actually keep track of tooth set.
We could phrase it "deciduous tooth set" yes/no.
Done.
@Jegelewicz need to create code tables for:
anatomical direction reference
tooth type
@dustymc we still need to do this.
/remind me to do this tomorrow
@dustymc set a reminder for Aug 21st 2020
:wave: @dustymc, do this
tables created
Thanks, now - how do we add stuff to anatomical direction reference when there are already things in those fields?
You can probably add values before you add the table to ctct control - if not I'll figure it out.
@dustymc I have added terms to the anatomical direction reference code table, but I haven't tried to associate it with the attribute type because there are some things that need to be corrected in the current data in order to match the code table. Here is a file that includes the part attributes that need to be updated with
GUID | PARTID | PART_NAME | ATTRIBUTE_TYPE | ATTRIBUTE_VALUE_OLD | ATTRIBUTE_VALUE_NEW
Can you SQL these in? Once that is done I will attempt to associate the code table with the attribute to see if anything goes haywire.
@Jegelewicz missing attachment
@Jegelewicz remind me what I'm supposed to do - I don't see any changes in your file?
@dustymc in the file the last two headers are attribute_value_old and attribute_value_new These changes need to be made before I associate the code table with the attribute so that stuff already in Arctos matches the code table. Clear as mud?
PS - many of them don't look functionally different because the "old" values have a trailing space...
many
I can't see any. I did this:
arctosprod@arctos>> update specimen_part_attribute set attribute_value=trim(attribute_value) where attribute_value!=trim(attribute_value);
UPDATE 44162
Anything left?
Looks like that did it. I have associated the attribute with the code table.
Thanks!