Arcade: Remove dependency of Microsoft.DotNet.VersionTools

Created on 5 Feb 2019  路  7Comments  路  Source: dotnet/arcade

https://github.com/dotnet/arcade/blob/e23b306673e647c087e629bbb2ef00ebb23938fb/src/Microsoft.DotNet.Build.Tasks.Feed/Microsoft.DotNet.Build.Tasks.Feed.csproj#L18

Microsoft.DotNet.VersionTools's source is in https://github.com/dotnet/buildtools/tree/master/src/Microsoft.DotNet.VersionTools
dotnet/buildtools it is not very well updated (still uses project.json). Arcade should not depend on such an old repo.

it should help issue https://github.com/dotnet/arcade/issues/1965 greatly.

Most helpful comment

VersionTools was added to Arcade by https://github.com/dotnet/arcade/pull/2213. You should be able to move to that now.

All 7 comments

I think Tasks.Feed is the only thing that uses VersionTools right now. If so I think it would be good to make this issue part of the publishing redesign epic.

cc @mmitche @markwilkie

ping. @mmitche @markwilkie I don't think this task should be in backlog. The new build framework should not have a dependency on an obsolete code base. I could not make contribution when I want/have to.

We workaround Arcade in nuget breaking change case eventually and made a product change instead. But that should not happen.

cc/ @riarenas and @chcosta who's looking at this from another context as well.

Yes @wli3 - we should not be depending on buildtools.

I'll see how this is being used, and if it's straightforward to remove as part of the publishing redesign we're already doing. If it takes additional changes, I probably won't touch this until the first part of the publishing pipeline is deployed and in use.

@wli3 Backlog simply means "we're not actively working on this right this instant." The issue is being taken into consideration as part of the completion criteria for https://github.com/dotnet/arcade/issues/1179

FYI there's a plan to move VersionTools to Arcade (https://github.com/dotnet/arcade/issues/1818#issuecomment-470204164). The Feed project could start depending on that instead of the version built by BuildTools, although continuing ahead with dependency removal might also be ok.

VersionTools was added to Arcade by https://github.com/dotnet/arcade/pull/2213. You should be able to move to that now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

JohnTortugo picture JohnTortugo  路  6Comments

missymessa picture missymessa  路  7Comments

suhsteve picture suhsteve  路  4Comments

dagood picture dagood  路  6Comments

jaredpar picture jaredpar  路  7Comments