Arcade: [darc/maestro++] Normalize branch names

Created on 17 Jul 2019  路  6Comments  路  Source: dotnet/arcade

We need to add branch names validation in a few places in the Maestro API to prevent users from inserting "invalid names". Valid branch names should match the format used by $(Build.SourceBranch) AzDO variable.

/cc @riarenas @mmitche

Most helpful comment

Yeah, normalizing is fine. At the end my point was really to maintain a consistent format all around in BAR.

All 6 comments

@JohnTortugo Do you mean forgetting the refs/heads bit for default channels, or entering a truly invalid git branch name?

Yeah, just missing the "refs/heads" part

I think we should just normalize the inputs, rather than rejecting requests without it. The refs/heads bit isn't that interesting from a user's perspective.

I was actually looking for an issue I thought I created about normalizing the branch names throughout the API, but I guess I never opened it. I agree we should just normalize.

Yeah, normalizing is fine. At the end my point was really to maintain a consistent format all around in BAR.

This was hit again twice by a user.

Was this page helpful?
0 / 5 - 0 ratings