Antennapod: "Smart Mark as Played" won't work if "Auto skip" is higher

[sbadux]

Hello,
I'm using AntennaPod 2 RC5 and I noticed that the "Smart Mark as Played" won't work if the podcast-specific "Auto Skip" option is set on an higher value.

E.g.
Set "Smart Mark as Played" to 30 seconds
Set "Auto Skip" for a podcast to 31 seconds or more.
The episode won't be set as played and stay in the queue

I think the app should set the episode as "played" considering the "Auto Skip" value if it's higher than the "Smart Mark as Played" value.

[ByteHamster]

@tonytamsf could you please have a look?

[tonytamsf]

Just noticed that I was tagged. Please assign to me

[tonytamsf]

@sbadux just confirming, with the 2.0.1 or 2.0.0 version are you still seeing this?

I assume you meant Auto Skip -> Skip last is set for 31 seconds? It seems to work for 2.0.1 on my phone

[sbadux]

@tonytamsf Hello,
I'm using the 2.0.2 and I still see this bug.

You assumption is right. I've set the "Skip Last" to 31 seconds or more and "Smart Mark as Played" to 30 seconds.
The playback automatically stops when there are 31 seconds left, but the Smart Mark as Played option doesn't remove it from the queue because the "30 seconds left" have not been reached.

I hope I was clear, but I can make a small video if you want to see the behaviour

[tonytamsf]

@sbadux thanks. What is your setting for 'Keep Skipped Episodes'?

[sbadux]

Keep Skipped Episodes

@tonytamsf This setting is Enabled in my app.

[tonytamsf]

Got it, now I can replicate the problem.

[tonytamsf]

Keep Skipped Episodes -> on
Set "Smart Mark as Played" to 30 seconds
Set "Auto Skip" for a podcast to 31 seconds or more.

@ByteHamster what do you think should happen? It feels like the episode should stay in the queue?

Otherwise I can change this function

https://github.com/AntennaPod/AntennaPod/blob/2a1dabf6029ac0f2f67fbc6c8ed1418e18bff671/core/src/main/java/de/danoeh/antennapod/core/feed/FeedMedia.java#L225

public boolean hasAlmostEnded() {
        int smartMarkAsPlayedSecs = UserPreferences.getSmartMarkAsPlayedSecs();
        return this.duration > 0 && this.position >= this.duration - smartMarkAsPlayedSecs * 1000;
    }

[tonytamsf]

@sbadux what is your setting for
Storage -> Auto Delete
Storage -> Delete removes from Queue

[richq]

This also seems to happen if the auto skip option is set to skip e.g. 35 seconds at the start and 0 at the end. The playback reaches the end of the episode that autoskipped some portion, it goes to the next podcast (which doesn't have any autoskip involved) in the Queue but the finished episode remains without autodelete and removed from queue. Not OP but I have auto delete and delete removes from queue enabled.

[tonytamsf]

@richq what is your setting for Keep Skipped Episodes?

[richq]

Keep Skipped is Enabled. FWIW also enabled is Continuous Playback, I use the built in Android player for media player and regular x1 playback speed.

[keunes]

Keep Skipped Episodes -> on
Set "Smart Mark as Played" to 30 seconds
Set "Auto Skip" for a podcast to 31 seconds or more.
what do you think should happen? It feels like the episode should stay in the queue

Agreed, because the episode is (auto)skipped _before_ the period in which the episode would be (smart) marked as played.
If the inverse, so autoskip kicks in when the episode would have been marked as played, it should be marked as played and thus not be kept in the queue.

At the same time we could argue: if autoskip kicks in, the user judged that the episodes 'finishes' earlier then the end of the file. And when the user considered the episode finished, so should the app. And thus the episode should be considered played 100% - thus not considered skipped - thus both the 'smart mark' and 'keep skipped' settings should be disregarded (as irrelevant).

We could even argue that 'smark mark as played' should add the autoskip time to the setting's own time. Meaning: of autoskip is 30s and smart mark is 15s, the episode should be marked played when hitting 'skip' at 40s before file end.

Thinking about it, I'm in favour of this second approach (considering an auto-skipped episode as fully played).

[sbadux]

@tonytamsf
Storage -> Auto Delete => ENABLED
Storage -> Delete removes from Queue => ENABLED

@keunes

Thinking about it, I'm in favour of this second approach (considering an auto-skipped episode as fully played).

Yes. I think that most of the users consider the autoskipped episodes as finished. AntennaPod should delete the episode IMHO. I think that most of the users use the auto-skip feature to skip the final music, advertising or greetings. I don't think that someone skips few seconds to keep the episode and listen it later for some seconds :-) .

[ByteHamster]

Thinking about it, I'm in favour of this second approach (considering an auto-skipped episode as fully played).

I agree. I think users consider "auto skip" basically as "trim episode", so when skipping the end, AntennaPod should mark as played regardless of the "smart mark as played" value.

[tonytamsf]

shoud be fixed https://github.com/AntennaPod/AntennaPod/pull/4594