Antennapod: [Translation] new tag should use singular while new used for tab listing those episodes should used plural

[Matth7878]

We use "new" word as a tab name in episodes screen along all and favorites.
For the tab when translated the plural form is the one to use as there is multiple episodes.

But the same label is used as tag on episodes which are new. And in this context it's the singular form which should be used as the tag apply to only one episode.

On transifex there is 2 "new" keys :
New_episodes_label
New_label
I think new_label should be the one used for tagging episodes and not new_episodes_label.

[keunes]

Hi @Matth7878,

Could you please confirm if I understand the issue correctly?

• the tab label should be plural
• the episode list entry label should be singular

If I interpret the code correctly, new_label is used for screen readers.

Given it's specific purpose, I'm not sure the same label can be used to visually display text. @ByteHamster?

I imagine we need a new label specific to the tab or episode list label, so that either can be made plural.

• New_episodes_label => tab label (current kept, for code consistency)
• New_episode_label => visual label in episodes lists (new string)
• New_label => audible label for screen readers in episode lists

I briefly checked for plural/singular use in different languages, and they seem to be mixed, so that doesn't provide any incentive for using New_episodes_label specifically for the tab or for the episode list.

[Matth7878]

You correctly understood :

• name for tab plural as it is a list with multiple episodes
• name displayed next to episode title singular since it's related to only one episode

Favorite is a good example. If text was used instead of a star then it would be "favorite".
But for tab name in episodes screen it is "favorites".
Hope it makes it clearer. :-)

[ByteHamster]

If I interpret the code correctly, new_label is used for screen readers.

Nope that's just a pretty strange way to set the text :D Not sure why it is done this way.

I briefly checked for plural/singular use in different languages, and they seem to be mixed, so that doesn't provide any incentive for using New_episodes_label specifically for the tab or for the episode list.

Yeah having two (or even more) translations probably is confusing to the translators.

new_label ==> Text (visual+screen reader) for episode status
new_episodes_label ==> Text for tabs

Looks like this line is wrong and should be either removed or replaced with new_label. I messed that up in 1313cde4812fa8daf26b7cb0fabd1349a2f39838 (probably because of the strange way to set text; see above).
https://github.com/AntennaPod/AntennaPod/blob/b0973d5c589466f52de58b73eae4b8aadfd9571c/app/src/main/res/layout/feeditemlist_item.xml#L94