Angular-gridster2: Big item can not push smaller item via push.pushItems

[MattMckeller]

Big item can not push smaller item via push.pushItems.

Have functionality to handle minimize & maximize of grid items. I set the size like the example:

const push = new GridsterPush(itemComponent); itemComponent.$item.rows = newRowCount; if (push.pushItems(push.fromNorth)) {...}

This fails when the maximized item has more rows than the items below it that need to be pushed.

[MattMckeller]

https://github.com/tiberiuzuld/angular-gridster2/issues/63

See this issue from the past for a better example of what I'm talking about, if you need more info I can provide.

For now my work-around is to just re-render the entire grid, but it seems in-efficient and looks choppy due to the loss of animations

[tiberiuzuld]

Hi @MattMckeller ,
Sorry didn't had the time yet to test it and check what is going wrong.
Will look over it tomorrow.
I assume you have latest version of the library.

[MattMckeller]

I do have the latest version of the library, yes.

[tiberiuzuld]

Hi @MattMckeller ,
Just tested on the new demo page and I cannot reproduce your issue.
https://tiberiuzuld.github.io/angular-gridster2/api

Let me know if you are able to reproduce it there.

Thanks

[MattMckeller]

When I said I was on the latest version I was on 4.7 or something, now I have updated to 5.0. However, the issue still exists but I'm unsure of how to reproduce the issue because it only happens if I change the # of rows on an item through the code as shown. It does not happen if I drag the items in the grid.

Perhaps I am going about resizing wrong is there an example somewhere I can double check? I will also try resizing by 1 row at a time rather than simply setting the expected # of rows. Once I have some time I will try to create a stackblitz to demonstrate the issue if this does not solve it. It could have to do with my configuration, I'm not sure.

[MattMckeller]

By the way, I really appreciate your help. and your package. Thank you,

Matt

[tiberiuzuld]

The link above, the page has a button to which will increase the row size. Pressing it 2 times pushes the item under it.

[tiberiuzuld]

Made it locally to increase the rows by 4 and still pushes the item.

[MattMckeller]

https://stackblitz.com/edit/angular-5whhjz

I cannot say for sure that this is an exact duplicate of the issue I'm having but it's one. Maybe it has something to do with the set number of columns + compacting.

Make sure to resize window to get out of mobile if you have this issue.

[tiberiuzuld]

Yes was able to reproduce is from the compact for some reason.
Didn't found the exact cause yet.

[tiberiuzuld]

So found the problem is not from compact.
Is how the items are set and how push works.
If the check here is commented out it will work.
https://github.com/tiberiuzuld/angular-gridster2/blob/master/src/lib/gridsterPush.service.ts#L134

The problem is that is there to stop reaching a infinite loop.
Don't know right now how to solve this issue.

Related to https://github.com/tiberiuzuld/angular-gridster2/issues/208

To reproduce this issue, on the demo api section set compactType: CompactType.CompactUpAndLeft

Any help will be greatly appreciated.

[MattMckeller]

Ok, good to know. I will definitely look into it when I have time!

[hungtcs]

Hi, I ran into the same problem in my project(ng v8), then found this issue.
The latest version seems to have fixed this problem.
I created two demo, one is version 8.x and another is version 10.x, if you drag the big item from right to left and then you can see the difference

• v8: https://stackblitz.com/edit/gridster-issues-281-ng8
• v10: https://stackblitz.com/edit/gridster-issues-281-ng10