Amp-wp: Remove "Your site does not allow AMP to be disabled" warning

[swissspidy]

As a user who wants to write a blog post, it's very unexpected to see the "Your site does not allow AMP to be disabled" warning when writing a blog post.

The warning is just shown without any context.

What if you don't even know that the site uses AMP under the hood?

Screenshot:

Suggestions/Options:

• Remove warning completely
• Show disabled AMP toggle with warning below
• Show disabled AMP toggle with warning shown in tooltip

[westonruter]

Agreed. That's a strange warning. Since you said it is a paired site, I don't understand why/how a theme could prevent it from being disabled. And only the amp_skip_post filter should be able to _prevent_ AMP from being used on a post, but it wouldn't _force_ AMP to be available.

[westonruter]

Yes, we should just remove this warning.

But we should actually remove the ability for a theme to prevent AMP from being disabled. The challenge is if a theme depends on AMP components, then disabling AMP will cause problems. But when Bento AMP is a thing and themes can depend on AMP components specifically, then themes can have AMP turned off and reliably use AMP components.

[pierlon]

@westonruter I think you're mistaken. If AMP has been disabled for a post with the amp_skip_post filter, the error message would be _"A plugin or theme has disabled AMP support."_.

In this case, the error message _"Your site does not allow AMP to be disabled."_ is shown when a plugin/theme forcibly set's a template as being supported or not via the amp_supportable_templates filter.

But we should actually remove the ability for a theme to prevent AMP from being disabled.

Would this also be applied for plugins?

[westonruter]

Ah, ok.

Would this also be applied for plugins?

Yes, as I don't think we'd be able to tell the difference between whether a theme or plugin is trying to prevent disabling.

In short, we'd be eliminating the immutable aspect of the supportable templates.

However, at the same time, the notices and the toggle here should only be exposed to users who have developer tools enabled. In other words, the notice could actually remain in place, to some degree but whether the AMP Enabled toggle (or the notice) are displayed as a whole should be gated behind whether a user has “developer tools” enabled, as noted in https://github.com/ampproject/amp-wp/issues/2673#issuecomment-542303464.

So this will mean that themes/plugins will continue to specify the default for whether a given template is enabled, and normal users won't be able to make any changes to that… but then users who have access to developer tools (who also have access to the admin screen, for example) can then make the decision for templates should be enabled for AMP. This may conflict with what the theme desires to be enabled/disabled for AMP, but in the coming world of Bento AMP the previous reason for immutable is going away: AMP components will be usable on non-AMP pages, so themes will be able to freely use them in their templates regardless of whether the page is being post-processed.

So long story short: the notices/warnings can actually remain, but we will suppress them and the AMP enabled toggle, if the user does not have developer tools enabled.

[westonruter]

Per https://github.com/ampproject/amp-wp/issues/2724#issuecomment-655912218, I'm now thinking that we should eliminate a whole bunch of stuff that has turned out to _not_ be useful over the years:

• The templates_supported flag.
• The immutable flag for templates supplied via the amp_supportable_templates filter.
• The paired flag.
• The available_callback flag (already removed in develop)

[pierlon]

QA Passed

When a template is disabled, the following (collapsible) notice is now shown:

If the user is not an administrator, the notice is not shown.