Amp-wp: Inserting pages while reordering

Created on 3 May 2019  路  4Comments  路  Source: ampproject/amp-wp

When you start the reordering, we basically copy the list of all the current pages and perform the reordering on that. Once you are done with the reordering, we update the actual order with the one from the copy. That's what allows you to cancel the reordering again.

Now, when you are reordering, you are still able to insert blocks and pages via the top toolbar. However, you won't see any new pages in the reordering panel because the copy hasn't been updated.

Some possible options here:

  • When adding new pages, add these to the end of the block order copy.
  • Disable/Hide all the buttons in the top toolbar when reordering.
  • Do nothing.
AMP Stories (obsolete) Bug

Most helpful comment

  • Disable/Hide all the buttons in the top toolbar when reordering.

I think this makes the most sense. When reordering, no one page is selected, so it doesn't make sense to have the top toolbar appearing.

All 4 comments

  • Disable/Hide all the buttons in the top toolbar when reordering.

I think this makes the most sense. When reordering, no one page is selected, so it doesn't make sense to have the top toolbar appearing.

Working On This If That's Alright

Hi @swissspidy,
If it's alright, I'm going to work on this.

See gif at #2266 for testing instructions / desired outcome

Thanks, @swissspidy

Verified in QA - Inserter and block options disabled when reordering:
image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

swissspidy picture swissspidy  路  3Comments

KhalidAlmallahi picture KhalidAlmallahi  路  4Comments

westonruter picture westonruter  路  3Comments

GitaStreet picture GitaStreet  路  4Comments

miina picture miina  路  5Comments