Amp-wp: Rename or replace gutenberg_get_jed_locale_data() usage

Created on 15 Nov 2018  路  3Comments  路  Source: ampproject/amp-wp

gutenberg_get_jed_locale_data() is now wp_get_jed_locale_data() in WordPress core.

The plugin currently fatals because of that.

The function should be renamed in the plugin and perhaps even considered to replaced in WP 5.0+ as per https://make.wordpress.org/core/2018/11/09/new-javascript-i18n-support-in-wordpress/.

See also #1604.

Bug Gutenberg
Source
picture swissspidy

Most helpful comment

And the function has now been removed from core. We need to address this again.

See https://core.trac.wordpress.org/changeset/43910

picture westonruter on 21 Nov 2018
👍2

All 3 comments

Either way, it doesn't hurt to add some function_exists() checks as is already done in \AMP_Post_Meta_Box.

swissspidy picture swissspidy on 15 Nov 2018

And the function has now been removed from core. We need to address this again.

See https://core.trac.wordpress.org/changeset/43910

westonruter picture westonruter on 21 Nov 2018
👍2

@swissspidy Can you figure out what needs to be done here for the 1.0-RC3 release tomorrow? /cc @kienstra

westonruter picture westonruter on 21 Nov 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

swissspidy picture swissspidy  路  4Comments
KhalidAlmallahi picture KhalidAlmallahi  路  4Comments
schlessera picture schlessera  路  5Comments
miina picture miina  路  5Comments
westonruter picture westonruter  路  4Comments