Hello @sd1998,
Contributions are always welcome!
To start contributing, I'll assume you know how to use git and write and debug Android apps - don't expect we can teach you ;)
We work with pull requests. Whatever any improvements, new features, bugfixes, submit your changes as pull requests. We will then
- start review your code for cleanliness and robustness
- test them to see if they work as you said
- merge the pull request
To speed up the review process, please
- of course, write your code clean. We also have our day time work, we are not able to correct your code for mistakes
- describe cleanly what your pull request do
- if you will be fixing a particular bug in the issue list, please explicitly say "Fixes #1441" in your description, for example
- while not required (because not everything can do automated tests), personally I'd recommend you to include Robolectric/Espresso tests in your pull request
Finally
- it's good to start a new branch to start your work, not just for a shiny branch name, but also for your own good
- we can be harsh when reviewing your work - I had my own days too - but because we want to have good code in our codebase. Be patient and carefully read our comments
- meanwhile, we may be wrong. Be patient too when arguing with us - we accept reason, but never accept hate speech
- I may have talked too much... but I think the above should be adequate for contributors of all levels. I should start a new issue for updating
CONTRIBUTING.md...
Ready to roll? Start forking ;)
Most helpful comment
Hello @sd1998,
Contributions are always welcome!
To start contributing, I'll assume you know how to use git and write and debug Android apps - don't expect we can teach you ;)
We work with pull requests. Whatever any improvements, new features, bugfixes, submit your changes as pull requests. We will then
To speed up the review process, please
Finally
CONTRIBUTING.md...Ready to roll? Start forking ;)