Amazefilemanager: Tapping "FTP server is running" notification should open FtpServerFragment directly

Created on 24 Sep 2018  路  2Comments  路  Source: TeamAmaze/AmazeFileManager

Steps to reproduce:

  1. Start FTP server, either via FtpServerFragment or Tile
  2. FTP server is started
  3. Go somewhere else but FtpServerFragment, e.g. Home screen, other app...
  4. Open task bar to open "FTP server is running" notification
  5. Tap on notification
  6. Returns to app, but not FtpServerFragment directly
Issue-Bug

Most helpful comment

Hello @sd1998,

Contributions are always welcome!

To start contributing, I'll assume you know how to use git and write and debug Android apps - don't expect we can teach you ;)

We work with pull requests. Whatever any improvements, new features, bugfixes, submit your changes as pull requests. We will then

  • start review your code for cleanliness and robustness
  • test them to see if they work as you said
  • merge the pull request

To speed up the review process, please

  • of course, write your code clean. We also have our day time work, we are not able to correct your code for mistakes
  • describe cleanly what your pull request do
  • if you will be fixing a particular bug in the issue list, please explicitly say "Fixes #1441" in your description, for example
  • while not required (because not everything can do automated tests), personally I'd recommend you to include Robolectric/Espresso tests in your pull request

Finally

  • it's good to start a new branch to start your work, not just for a shiny branch name, but also for your own good
  • we can be harsh when reviewing your work - I had my own days too - but because we want to have good code in our codebase. Be patient and carefully read our comments
  • meanwhile, we may be wrong. Be patient too when arguing with us - we accept reason, but never accept hate speech
  • I may have talked too much... but I think the above should be adequate for contributors of all levels. I should start a new issue for updating CONTRIBUTING.md...

Ready to roll? Start forking ;)

All 2 comments

@TranceLove @EmmanuelMess I would like to start contributing to this project could you point me in the right direction. I would like to work on this issue.

Hello @sd1998,

Contributions are always welcome!

To start contributing, I'll assume you know how to use git and write and debug Android apps - don't expect we can teach you ;)

We work with pull requests. Whatever any improvements, new features, bugfixes, submit your changes as pull requests. We will then

  • start review your code for cleanliness and robustness
  • test them to see if they work as you said
  • merge the pull request

To speed up the review process, please

  • of course, write your code clean. We also have our day time work, we are not able to correct your code for mistakes
  • describe cleanly what your pull request do
  • if you will be fixing a particular bug in the issue list, please explicitly say "Fixes #1441" in your description, for example
  • while not required (because not everything can do automated tests), personally I'd recommend you to include Robolectric/Espresso tests in your pull request

Finally

  • it's good to start a new branch to start your work, not just for a shiny branch name, but also for your own good
  • we can be harsh when reviewing your work - I had my own days too - but because we want to have good code in our codebase. Be patient and carefully read our comments
  • meanwhile, we may be wrong. Be patient too when arguing with us - we accept reason, but never accept hate speech
  • I may have talked too much... but I think the above should be adequate for contributors of all levels. I should start a new issue for updating CONTRIBUTING.md...

Ready to roll? Start forking ;)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

TjrGithub picture TjrGithub  路  5Comments

Wilker-a picture Wilker-a  路  5Comments

MagTun picture MagTun  路  4Comments

mirh picture mirh  路  4Comments

spocko picture spocko  路  4Comments