Aframe: laser-controls should use trigger for GearVR

[machenmusik]

Currently, laser-controls uses trackpad button for both Daydream (which has no trigger) and for GearVR. However, the GearVR controller does have a trigger, and A-Frame should use that by default for consistency with native usage.

For example, at the moment one uses the trigger to click the enter VR button when on an A-Frame laser-controls page in Oculus Browser on GearVR, but then one needs to start using the trackpad instead once in VR, which seems / feels odd.

[machenmusik]

https://github.com/aframevr/aframe/blob/master/src/components/laser-controls.js#L73

[payamspot]

"help wanted" you mean test it on GearVR? @dmarcos

[payamspot]

I have GearVR with controller, what should i change in my code to test this?

[machenmusik]

I think "help wanted" means looking for folks to submit the fix as a pull request to this A-Frame source code repository... and "(easy)" means the required change is simple / straightforward so it is ideal for first-time participants.

Basically, just need to make the GearVR line mentioned above that specifies trackpad down and up
look like the other lines that specify trigger down and up instead.

[payamspot]

Thank you so much for explaining @machenmusik

[payamspot]

done :) hopefully i did it correctly

[dmarcos]

@payamspot you did it good 🙂It would be nice to leave it for someone that has not contributed yet. Are you ok with that?

[dmarcos]

We can take your PR if nobody volunteers

[payamspot]

sure @dmarcos that's a great idea. although it's my 4th contribution on github ever :)

[dmarcos]

@payamspot yeah, you know the drill already. Some people feel intimidated and having some issues like this one are good to build confidence. You’re alredy in pretty good shape

[machenmusik]

many thanks @payamspot for your patience and understanding!

[DougReeder]

The trackpad on the Controller corresponds to the trackpad on the headset. Has this been tested to ensure users with only a headset can still use laser-controls, with the trackpad button?

[machenmusik]

I am not sure that would have worked in the first place actually, unless you have both controller and trackpad, since the GearVR trackpad on the side of the headset does not have a pose, and therefore will not be utilized by tracked-controls which laser-controls builds upon...

[DougReeder]

The description of laser-controls implies that it downgrades to a gaze cursor when no 3DOF or 6DOF controller is available. However, you're right, it does not actually do so. :-(

Proceed!

[DigiTec]

I'd like to warn, that Right Trigger AND Touchpad on the Gear VR controller map to the same thing. For this reason we would expect that if using laser-controls either input would be allowed. We originally did not want the trigger to be activation because we wanted it to be grab, but its like a 50/50 split as to whether or not people use the touchpad or Trigger when activating something, so we wound up just mapping both to the same action and giving up on having the extra button be used for something else.

[machenmusik]

Thanks @DigiTec - so for native consistency it should have both sets of events rather than one or the other

[ngokevin]

https://github.com/aframevr/aframe/pull/3530