Addons-frontend: Layout issue when resizing `All reviews` page using Responsive Design Mode

Created on 20 May 2020  路  10Comments  路  Source: mozilla/addons-frontend

Followup for https://github.com/mozilla/addons-frontend/issues/8396#issue-473403723

Similar with https://github.com/mozilla/addons-frontend/issues/4108

Resizing this page with Responsive Design Mode https://addons.allizom.org/en-US/firefox/addon/search_by_image/reviews/716646/?src=rating somewhere between 720 ~790px width the name of the reviewer and the text are not entirely displayed.

This is reproducible when the name of the reviewer is a long unbroken string. The review is a text with or without spaces.

edge case

I tested on FF76(Win10) - AMO stage.

ux maybe good first bug p3 verified fixed bug

Most helpful comment

This is similar to https://github.com/mozilla/addons-frontend/issues/9432. It's probably just a simple css fix, but not a high priority as it's unlikely that the name of a reviewer would be a long unbroken string in the wild.

All 10 comments

This is similar to https://github.com/mozilla/addons-frontend/issues/9432. It's probably just a simple css fix, but not a high priority as it's unlikely that the name of a reviewer would be a long unbroken string in the wild.

@willdurand This is still reproducible on AMO dev

cut

@ioanarusiczki could you please share a link in -dev?

@willdurand Same problem. It is AMO stage. Brb

@willdurand Same problem. It is AMO stage. Brb

@ioanarusiczki so AMO stage hasn't been patched yet?

@willdurand As far as I know if it has this week's milestone this should go only Wednesday on stage.

However, I tested on dev and I changed the name of the user from a long unbroken string of 50 chars to one with spaces but I used the maximum of 50.
I see the date "2 months ago" and some words cut (maximum 2 chars missing), maybe 2 letters from the display name too are missing.

https://addons-dev.allizom.org/en-US/firefox/addon/dark22reader/reviews/564593/

Ok, so this is indeed a problem. mmmm

@ioanarusiczki I added another fix.

@willdurand Looks good to me. Verified on AMO dev with FF76(Win10).

Bugfix

Was this page helpful?
0 / 5 - 0 ratings