Addons-frontend: Description text box should have only a vertical expansion

[ioanarusiczki]

STR:

1. Load AMO dev and go to View my collection
2. Click one of the collections then edit my collection button
3. Mouse hover over the right edge of the box and expand it towards the list of extensions/themes

Actual result:
Extensions/themes overlap the text box.

Expected result:
The box won't expand over the list of extensions/themes.

Notes:
When the list of add-ons is empty the placeholder text "Search for extensions and themes to add to your collection" looks like it's in the text box.
This issue is reproducible on AMO dev and AMO stage with FF61(Win10).

[caitmuenster]

Mentor: @rebmullin

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

[suhailsinghbains]

Hi, I am new to contributions for Mozilla, can I please be assigned this issue, would love to work on it.

[championshuttler]

Hi @suhailsinghbains thanks for your interest. Go for it! If you need any help, please feel free to ask here :wink:

[suhailsinghbains]

Okay, thanks @championshuttler . Working on it right away!

[suhailsinghbains]

I thought I would figure out the file that needs to be changed, but, was not successful at that.
Please tell the file that require the change.

[championshuttler]

Hi @suhailsinghbains if I am not wrong the source for files you are looking for is here src/amo/components/CollectionDetails

[suhailsinghbains]

Okay, thanks

[suhailsinghbains]

My old PC is not working properly, I'll load the project onto my new PC, will update you soon.

[suhailsinghbains]

I did a lot research, can't just past this step.
Please if someone could help me.

[championshuttler]

Hi @suhailsinghbains, as the error in the attached screenshot, you have to use node version =>6 <=8.
This means please use node version 6 or more but less than 8 . You can use nvm to use different node versions ;)

Let us know if you need any other help :smile:

[suhailsinghbains]

I had to make some packages, delete some, all in all, the project works, now, this shohuldn't take long, I hope

[suhailsinghbains]

@championshuttler Hi, the issue has been solved, should I make another branch addressing my issue or just make a simple Pull Request.

[willdurand]

@championshuttler Hi, the issue has been solved, should I make another branch addressing my issue or just make a simple Pull Request.

A Pull Request starts from a branch, but it does not matter which one as far as you have only the commit(s) for fixing this issue in that branch (and not other commits for other issues for example). Usually, we create one branch per issue to keep things separated and we avoid to work on the main branch (master) but this is up to you :)

[suhailsinghbains]

Okay, I'll use the branch method.
Thanks for your help @willdurand !

[willdurand]

Amazing first contribution @suhailsinghbains!

[suhailsinghbains]

Thank you so much @willdurand & @championshuttler for mentoring me !!

[ioanarusiczki]

Verified fixed on AMO dev with FF61(Win10)

I filed a separate issue https://github.com/mozilla/addons-frontend/issues/5988 for what I've noticed while testing this one.