Addons-frontend: Enable the download button for incompatible clients (link to extension source)

[muffinresearch]

Following on from: https://github.com/mozilla/addons/issues/703

We should look to leave the "install" button enabled for incompatible clients so that users that user privacy.resistFingerprinting set to true can still install add-ons.

We'll need to figure out the correct wording in this case as well as make sure the JS API falls-back to the add-on link gracefully for incompatible UAs.

[muffinresearch]

@jvillalobos is there anything else you'd like to be considered for this issue?

[jvillalobos]

It's not only non-Fx UAs, but also incompatible versions, since that's what the preference changes.

[muffinresearch]

It's not only non-Fx UAs, but also incompatible versions, since that's what the preference changes.

Thanks, I've updated the description.

[willdurand]

@muffinresearch is this still needed? I know some users find the link to the xpi _via_ the install button already.

[gavinr]

I am having this issue, and I suspect others are running into this too.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

[gavinr]

This should not be closed, see discussion here: https://discourse.mozilla.org/t/browser-detection-incorrect/48787

[bobsilverberg]

@jvillalobos Do we know how we want this to look? I was imagining a simple text link under the button that can be used to download the xpi. Do we want this in cases where the download button is disabled and also in cases where the button is a "Download Firefox" button? If we're going with a text link (or a button for that matter), what should the text read?

[jvillalobos]

I was imagining a simple text link under the button that can be used to download the xpi.

A simple text link is what I had in mind, yeah.

Do we want this in cases where the download button is disabled and also in cases where the button is a "Download Firefox" button?

Yes

what should the text read?

"Download file"

[willdurand]

Note that when we have the Install button, the XPI link is available with a right click in some cases. I like the idea of a small-ish text below the button with the direct link to the XPI, though.

[bobsilverberg]

@jvillalobos Here are some examples of what I've done. Note that I made the link grey and lighter to make it less noticeable. Please let me know if you'd like to see style changes.

[jvillalobos]

Can you please add an underline so it is clearer that it's a link? I'm also slightly curious why the spacing between the button and the link changes in some screenshots. It's very close to the button for some of them.

[bobsilverberg]

I'm also slightly curious why the spacing between the button and the link changes in some screenshots. It's very close to the button for some of them.

That was a result of a style in place for the mobile view. I've fixed that so that in all sizes there is the same 12px gap between the button and the link, and I've added the underline:

[AlexandraMoga]

I've verified several instances in which the Install button is disabled:

[1] - Incompatible Firefox version (needs lower version)

[2] - Incompatible Firefox version (needs higher version)

[3] - Incompatible platform

[4] - Browser other than Firefox

@bobsilverberg On non-Firefox browsers and on Android, the Download file link will trigger the .xpi download to the file system while In Firefox desktop, the link will trigger an installation (see example). It is not clear from the requirements if an installation is to be expected, or if the download button should always trigger an actual file download.

[Rob--W]

On non-Firefox browsers and on Android, the Download file link will trigger the .xpi download to the file system while In Firefox desktop, the link will trigger an installation (see example). It is not clear from the requirements if an installation is to be expected, or if the download button should always trigger an actual file download.

This is expected for now, as Firefox for Android (Fenix) doesn't support installations of xpi files yet.

[cadeyrn]

I guess the question was more about the other part:

while In Firefox desktop, the link will trigger an installation

I don't expect that a "Download file" link triggers an installation, I expect it to trigger a download of the file.

[AlexandraMoga]

Filed #9679 as a follow up