Adaptivecards: [iOS][input validation error] [UX issue : Input view styling on validation error]

Created on 28 Sep 2020 · 6Comments · Source: microsoft/AdaptiveCards

Platform

What platform is your issue or question related to?

Author or host

Host - Teams iOS Client

Version of SDK

SDK 2.1.0 (Adaptive card v1.3)

Details

When there is an input validation error message on the card, the SDK adds the border and changes the border colour of the inputView.

The SDK gets the inputView from the input stack and applies a colour filter to it assuming that the inputView would use the default renderer and this logic is present in validate method in ACRInputLabelView.mm and there is no new host config to pick this border colour.

    self.stack.arrangedSubviews[1].layer.borderWidth = 1;
    self.stack.arrangedSubviews[1].layer.cornerRadius = 6.0f;
    self.stack.arrangedSubviews[1].layer.borderColor = UIColor.systemRedColor.CGColor;

But in case the host uses a custom input renderer with its inputView, the UX we want should be based on the current theme/host config. There is no place where the host can override this behaviour of getting the input view and applying the border/colour filter to it.

PFA screenshot of the default behaviour and expected host behaviour (teams client) :

Default behaviour :

Expected behaviour :

AdaptiveCards v20.10 Area-Inconsistency Bug Msft-TeamsMobile MsftTeams-Integration Priority-Normal Triage-Approved for Fix

Source

jyoti-ms

All 6 comments

please review this issue for target Milestone, Inconsistencies & Priority upon triage.

msftbot[bot] on 28 Sep 2020

@shalinijoshi19 @dclaux @jwoo-msft We are facing this issue as we are upgrading to the latest SDK in Teams. Can you please triage and let us know how we can work around this.
FYI: @sowrabh-msft @VikrantSingh01

jyoti-ms on 28 Sep 2020

Hi @jyoti-ms. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

msftbot[bot] on 29 Sep 2020

Fixed via https://github.com/microsoft/AdaptiveCards/pull/4853
Please see https://github.com/microsoft/AdaptiveCards/pull/4852 for the usage.