Zwavejs2mqtt: Dimmers no longer go to 100% in rc0

[jcam]

Version

Build/Run method

• [ ] Docker
• [ ] PKG
• [X] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: 1.0.0-rc.0

Describe the bug
Attempting to set the brightness of a standard (non-RGB) dimmer no longer will go to 100%.

To Reproduce
Steps to reproduce the behavior:

1. Deploy zwavejs2mqtt rc.0
2. Set the brightness of a dimmer to 87% in HASS
3. Observe that the light is much dimmer than expected
4. Observe that the dim level displayed in HA has snapped down to a much lower level than selected
5. In the zwavejs2mqtt log:
   2021-01-20 03:18:46.390 INFO MQTT: Message received on homeassistant/DiningRoom/13/38/0/targetValue/set, '87'
   2021-01-20 03:18:46.401 INFO ZWAVE: Writing 34 to 38-0-targetValue

Expected behavior
The dimmer should dim to the value selected. Swapping out zwavejs2mqtt and keeping everything else the same (HA version, dimmer in question, MQTT settings, zwave-js version) yields a dim of 87%

Additional context
node_13.zip

[blhoward2]

Note that by math we figured out HA is sending 87/99 but the dimmer is acting on 87/255.

[robertsLando]

Ok So this is due to

https://github.com/zwave-js/zwavejs2mqtt/blob/master/lib/Gateway.js#L713

It has always been there, I know someone reported it as working for dimmers as they send values from 0-255 and dimmers get values 0-99. Now if you say it's not used I will remove it

[robertsLando]

@jcam Could you try with #290? It should fix 2 of your issues

[blhoward2]

Isn’t that calculation already done in the math of the command_on topic in the switch discovery? You’re doing that same math there.

"command_on_template": "{{ ((brightness / 255 * 99) | round(0)) if brightness is defined else 255 }}",

[robertsLando]

Isn’t that calculation already done in the math of the command_on topic in the switch discovery? You’re doing that same math there.

The question is, why it was working before :laughing:

[robertsLando]

@blhoward2 Please give that branch a try

[blhoward2]

@blhoward2 Please give that branch a try

@robertsLando I'm not on master because the basic set one is behind, so I haven't encountered the issue. @Jesse should test that PR.

[robertsLando]

@blhoward2 ok now it is, the PR about CC basic has been merged

[jcam]

I've tested with #290 , it fixes this issue, thanks! Testing the others now...

[blhoward2]

@blhoward2 ok now it is, the PR about CC basic has been merged

This also works fine for me, though I wasn't on master so I can't confirm that I was experiencing the problem to begin with...

[towerhand]

Is there an easy way to pull this fix with docker compose? Or would it be easier to wait until is merged and pull it with the dev tag?

[blhoward2]

You can build it pretty easily with docker. Follow the directions at the bottom here to clone the zwave2jsmqtt repo so you have the dockerfile. https://github.com/zwave-js/zwavejs2mqtt/tree/master/docker

Then run the following from the folder above the repo:

DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=fix-dimmers --build-arg ZWJ_BRANCH=master --no-cache -f zwavejs2mqtt/docker/Dockerfile.contrib -t zwavejs2mqtt .

[towerhand]

Thanks @blhoward2, I'll give it a try.

Edit: that worked, thanks for pointing me on the right direction.

[jcam]

Resolved by #290