Zwavejs2mqtt: [bug] Removed node breaks network graph

Created on 6 Jan 2021  路  4Comments  路  Source: zwave-js/zwavejs2mqtt

Version

Build/Run method

  • [x] Docker
  • [ ] PKG
  • [ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: v1.0.0-alpha.2

Describe the bug
A removed node (node id 5 was excluded) breaks the network graph. Seems to be similar to the closed issue #87.

Frontend console throws this exception:

vue.esm.js:1897 Error: missing: 5
    at D (vue-d3-network.umd.js:5313)
    at d (vue-d3-network.umd.js:5363)
    at Function.B.u.initialize (vue-d3-network.umd.js:5394)
    at f (vue-d3-network.umd.js:5727)
    at Object.force (vue-d3-network.umd.js:5769)
    at o.simulate (vue-d3-network.umd.js:7753)
    at o.animate (vue-d3-network.umd.js:7785)
    at o.reset (vue-d3-network.umd.js:7789)
    at o.netLinks (vue-d3-network.umd.js:7633)
    at pn.run (vue.esm.js:4577)

To Reproduce
Exclude a node from the network.

Expected behavior
Graph should still be working.

Additional context
Replicated in :latest and :dev tags.

bug

All 4 comments

A network heal and then restart of the Docker container brought back the network graph and made the exception go away.

@AlCalzone I have a feeling that this is caused by node neighbors not updated when a node is removed

Yeah basically we would have to tell all nodes to update their neighbors when a node is added or removed

I already have created an issue to track this

Was this page helpful?
0 / 5 - 0 ratings