Zulip-desktop: Remove deprecated request module

[andersk]

The request module is deprecated. Although it is still used by our indirect dependencies, we should replace our direct uses of it.

[akashnimare]

Damn, just came to know about this. Will have to explore alternatives now.

[Bearbobs]

Moving to something like axios or urlib can be a good solution

[akashnimare]

Yeah, gotta see if those satisfy our requirements (proxy support etc).

[andersk]

I do feel compelled to ask: given that Electron is, you know, a web browser…do we actually need a separate third-party library to make web requests? Can we just use electron.net?

[Bearbobs]

electron.net is another fork of request module, I guess

[andersk]

I don’t see any evidence of that. But that wouldn’t matter; the Electron developers will maintain electron.net regardless of what happens to any modules it may or may not be a fork of.

[timabbott]

Yeah, it seems like switching to electron.net makes a lot of sense.

[Bearbobs]

@andersk makes sense, can I please work on migrating request to electron.net?

[akashnimare]

@Bearbobs can you first check if we can use it in the renderer process or not?

[Bearbobs]

on it, will revert back @akashnimare.
Thanks,

[Bearbobs]

@akashnimare yes we can use it for the renderer process, it's quite straight forward as the request package

[Somtozech]

Anyone working on this already?

[Bearbobs]

@Somtozech me

[Bearbobs]

@akashnimare @timabbott
https://chat.zulip.org/#narrow/stream/16-desktop/topic/GSoC-2020/near/833454

[PawBud]

Any updates on this @Bearbobs?

[PawBud]

Is this issue claimed?