Zulip-desktop: Error: Invalid URI "../renderer/img/icon.png"

[abhigyank]

This error occurs when we try to saveServerIcon with ../renderer/img/icon.png (which is a fallback icon in case we are unable to get the icon while adding the server) as url parameter, since we then do request to this file which leads to this error obviously.
I think we can have a check not to do a request to the request if the url is this file. This will reduce this error.

[abhigyank]

@zulipbot label "good first issue" "Type: Bug"

[aashish-ak]

@zulipbot claim

[zulipbot]

Hello @aashish-ak, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[ShivangiKakkar]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @ShivangiKakkar! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[zulipbot]

Hello @ShivangiKakkar, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[ghost]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @flowkraD! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[zulipbot]

Hello @flowkraD, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[kanishk98]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @kanishk98! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[kanishk98]

@abhigyank Hi. I'm just starting out with contributing to Zulip, and it'd be great if you could provide me with some directions on how to reproduce the issue on my end.
If it helps, the only organisation I've added so far has been chat.zulip.org itself, and I haven't seen any console logs I added to saveServerIcon show up.

[abhigyank]

Hello @kanishk98 , you'd be able to reproduce the error if you add a server like "abhigyank.zulipdev.org". The error occurs due to an invalid image path in of defaultIcon in domain-util.js .

[kanishk98]

@abhigyank thanks for the info. I'll get to work and let you know if I have any questions. :)

[kanishk98]

Okay, on the surface, this just seems to be a wrong file path issue. @abhigyank this can be solved simply by replacing ../renderer/img/icon.png with ../../img/icon.png for the saveServerIcon() method to find the appropriate image.
I'm unsure of whether this is the best way to solve the issue though.

[abhigyank]

Looks correct to me for now.
@akashnimare can you weigh in?

[zulipbot]

Hello @kanishk98, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[kanishk98]

@abhigyank looks like @zulipbot is flaring up. I'll submit a PR asap regardless; we can fix other things from there.

[aashish-ak]

@zulipbot claim

[zulipbot]

Hello @aashish-ak, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[zulipbot]

Welcome to Zulip, @ananyaarun! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[zulipbot]

Hello @Swapnilr1, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[ananyaarun]

@zulipbot abandon

[Swapnilr1]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @Swapnilr1! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[Swapnilr1]

@abhigyank Can you tell me how to replicate this issue? Also I see kanishk98 had made a commit regarding this. Did it not fix the issue? Or was it not merged?

[abhigyank]

Hello @Swapnilr1 I highly doubt kanish98's solution will work here or even the PR of flowkraD.
The issue here is that defaultIconUrl is a file:// protocol link and request is able to entertain only http or https endpoints. So in this case a different approach is required to fix the issue even after correcting the path in defaultIconUrl .
Regarding reproducing this issue, see https://github.com/zulip/zulip-electron/issues/533#issuecomment-433619139

[Swapnilr1]

@abhigyank So should I sign-up for abhigyank.zulipdev.org and add it to the Electron app, or is there a way to locally load such a server?

[abhigyank]

@Swapnilr1 there is no need to signup on the server. You can simply add it to the electron app in add organization page. That should be sufficient to reproduce the issue I suppose,

[Swapnilr1]

@abhigyank After running npm run dev and then adding abhigyank.zulipdev.org where should I be able to see this error?

[akashnimare]

@Swapnilr1 in the console tab of developer tools.

[Swapnilr1]

@akashnimare Thanks a lot. Working on it.

[Swapnilr1]

@zulipbot claim

[zulipbot]

Hello @Swapnilr1, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

[Nikhil-Vats]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @NikhilPhalange! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-electron/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Sign the Dropbox Contributor License Agreement, so that Zulip can use your code.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[Swapnilr1]

@NikhilPhalange I have already fixed this issue and my PR is pending review.

[Nikhil-Vats]

@zulipbot abandon

[Somtozech]

@zulipbot claim

[zulipbot]

Welcome to Zulip, @Somtozech! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

• Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
• Unwatch this repository, so that you don't get 100 emails a day.

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

[Somtozech]

@abhigyank can i work on this issue?. There seem to be some PR's that solve the issue already

[abhigyank]

The PR already seems to solve this issue, which I think is still redundant. I'd suggest not working on this issue.