Zipkin: Enable CORS for zipkin-server

Created on 16 Jun 2016  路  2Comments  路  Source: openzipkin/zipkin

Enabling CORS headers (Access-Control-Allow-Origin: *) in the Zipkin query API will allow API access from UI applications running on different hosts, which seems very useful. Is there a reason not to enable this by default?

enhancement server
Source
picture mikewrighton

Most helpful comment

Sounds fine to me.. implementation would be to add @CrossOrigin onto ZipkinQueryApiV1

@gena01 @marcingrzejszczak @shakuzen unless you know a reason not to, let's make this change

picture adriancole on 21 Jun 2016
👍3

All 2 comments

+1
No reason, except nobody has made a PR yet :wink:

eirslett picture eirslett on 17 Jun 2016

Sounds fine to me.. implementation would be to add @CrossOrigin onto ZipkinQueryApiV1

@gena01 @marcingrzejszczak @shakuzen unless you know a reason not to, let's make this change

adriancole picture adriancole on 21 Jun 2016
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

schrepfler picture schrepfler  路  7Comments
h-karaki picture h-karaki  路  8Comments
nolan4954 picture nolan4954  路  10Comments
adriancole picture adriancole  路  6Comments
kmalecki picture kmalecki  路  9Comments