Zigbee2mqtt: How to add an 'undefined' device to device.js (Stelpro Orleans baseboard)

Created on 5 Jan 2019 · 38Comments · Source: Koenkk/zigbee2mqtt

I have a problem while trying to add a Stelpro Orleans integrated zigbee thermostat, here is part of the log while pairing device:

_zigbee2mqtt:info 2019-1-5 16:01:20 Connecting with device...
zigbee2mqtt:info 2019-1-5 16:01:20 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-5 16:01:20 Message without device!
zigbee2mqtt:info 2019-1-5 16:01:21 Connecting with device...
zigbee2mqtt:info 2019-1-5 16:01:21 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-5 16:01:21 Message without device!
zigbee2mqtt:info 2019-1-5 16:01:23 Connecting with device...
zigbee2mqtt:info 2019-1-5 16:01:23 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-5 16:01:23 Message without device!
zigbee2mqtt:info 2019-1-5 16:01:26 Connecting with device...
zigbee2mqtt:info 2019-1-5 16:01:26 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-5 16:01:26 Message without device!
zigbee2mqtt:info 2019-1-5 16:01:28 Connecting with device...
zigbee2mqtt:info 2019-1-5 16:01:28 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-5 16:01:28 Message without device!
zigbee2mqtt:info 2019-1-5 16:01:28 Connecting with device...
zigbee2mqtt:info 2019-1-5 16:01:28 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-5 16:01:28 Message without device!
zigbee2mqtt:info 2019-1-5 16:01:28 Device incoming...
zigbee2mqtt:info 2019-1-5 16:01:28 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"device incoming"}'
zigbee2mqtt:info 2019-1-5 16:01:28 New device with address 0xf8f005fffff89588 connected!
zigbee2mqtt:info 2019-1-5 16:01:28 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"device_connected","message":"0xf8f005fffff89588"}'
zigbee2mqtt:warn 2019-1-5 16:01:28
zigbee2mqtt:warn 2019-1-5 16:01:28 Please see: https://koenkk.github.io/zigbee2mqtt/how_tos/how_to_support_new_devices.html
zigbee2mqtt:warn 2019-1-5 16:01:28 Device with modelID 'undefined' is not supported.
zigbee2mqtt:warn 2019-1-5 16:01:28 Please see: https://koenkk.github.io/zigbee2mqtt/how_tos/how_to_support_new_devices.html

Reading the how_to_support_new_devices.htm documents, it mentions that once the device is paired, if it is unsuported we should add the device in the device.js but since the _modelID_ is 'undefined' how should I create it ?

looking in the database.db, I found somewhere that the modelId was STE218, I tried with this in the device.js and rebooted but when I change the temperature on the thermostat nothing isn catch by the zigbeetomqtt.

Any toughts ?

p.s. I saw in the database.db that there are few instances for the same device

database.docx

Source

goldriver2

All 38 comments

Hi,
the pairing did not provide the modelId in the header but in the ep record!
just to start , i would suggest to add "modelId": "ST218", in the DB after "manufId": 4485,
after that restart zigbee2mqtt and will still see that ST218 is not supported
Now you can follow https://koenkk.github.io/zigbee2mqtt/how_tos/how_to_support_new_devices.html

see #556 for more info

khzd on 6 Jan 2019

Ok I started back from the beginning
-I stopped zigbteetomqtt
-I erased the database.db
-I remove the information relating to the thermostat in the configuration.yal
-I reset the stelpro thermostat
-I start back the zigbeetomqtt
-I looked in database.db and configuration.yaml to make sure there was no signs of the thermostat
-I activated the pairing on the ST218
-I got the above in the LOG

zigbee2mqtt:warn 2019-1-6 08:08:58 Message without device!
zigbee2mqtt:info 2019-1-6 08:09:05 Connecting with device...
zigbee2mqtt:info 2019-1-6 08:09:05 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-6 08:09:05 Message without device!
zigbee2mqtt:info 2019-1-6 08:09:07 Connecting with device...
zigbee2mqtt:info 2019-1-6 08:09:07 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-6 08:09:07 Message without device!
zigbee2mqtt:info 2019-1-6 08:09:07 Connecting with device...
zigbee2mqtt:info 2019-1-6 08:09:07 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"connecting with device"}'
zigbee2mqtt:warn 2019-1-6 08:09:07 Message without device!
zigbee2mqtt:info 2019-1-6 08:09:07 Device incoming...
zigbee2mqtt:info 2019-1-6 08:09:07 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"pairing","message":"device incoming"}'
zigbee2mqtt:info 2019-1-6 08:09:07 New device with address 0xf8f005fffff89588 connected!
zigbee2mqtt:info 2019-1-6 08:09:07 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"device_connected","message":"0xf8f005fffff89588"}'
zigbee2mqtt:warn 2019-1-6 08:09:07 Device with modelID 'undefined' is not supported.
zigbee2mqtt:warn 2019-1-6 08:09:07 Please see: https://koenkk.github.io/zigbee2mqtt/how_tos/how_to_support_new_devices.html
zigbee2mqtt:warn 2019-1-6 08:09:07 Device with modelID 'undefined' is not supported.
zigbee2mqtt:warn 2019-1-6 08:09:07 Please see: https://koenkk.github.io/zigbee2mqtt/how_tos/how_to_support_new_devices.html

No I have 3 lines with the same id in the the database.db:

{"id":2,"type":"Router","ieeeAddr":"0xf8f005fffff89588","nwkAddr":54989,"manufId":4485,"epList":[25],"status":"online","joinTime":1546780137,"endpoints":{"25":{"profId":260,"epId":25,"devId":769,"inClusterList":[0,3,4,513,516],"outClusterList":[1026],"clusters":{}}},"_id":"xsLNRH73hBUsQ2Zp"}
2.{"id":2,"type":"Router","ieeeAddr":"0xf8f005fffff89588","nwkAddr":54989,"manufId":4485,"manufName":"Stelpro\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","powerSource":"Mains (single phase)","epList":[25],"status":"online","joinTime":1546780137,"endpoints":{"25":{"profId":260,"epId":25,"devId":769,"inClusterList":[0,3,4,513,516],"outClusterList":[1026],"clusters":{}}},"_id":"xsLNRH73hBUsQ2Zp"}
{"id":2,"type":"Router","ieeeAddr":"0xf8f005fffff89588","nwkAddr":54989,"manufId":4485,"manufName":"Stelpro\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","powerSource":"Mains (single phase)","epList":[25],"status":"online","joinTime":1546780137,"endpoints":{"25":{"profId":260,"epId":25,"devId":769,"inClusterList":[0,3,4,513,516],"outClusterList":[1026],"clusters":{"genBasic":{"dir":{"value":1},"attrs":{"zclVersion":1,"appVersion":104,"stackVersion":3,"hwVersion":1,"manufacturerName":"Stelpro\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","modelId":"ST218\u0000\u0000\u0000(\u0001](\u0001S\b\u0000\u0001X%\u0004\u0000��\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","dateCode":"20170126 00111\u0000","powerSource":1}},"genIdentify":{"dir":{"value":1},"attrs":{"identifyTime":170,"identifyCommissionState":0}},"genGroups":{"dir":{"value":1},"attrs":{"nameSupport":0}},"hvacThermostat":{"dir":{"value":1},"attrs":{"16385":-32768,"16412":4,"localTemp":2150,"outdoorTemp":-32768,"ocupancy":1,"absMinHeatSetpointLimit":500,"absMaxHeatSetpointLimit":3000,"absMinCoolSetpointLimit":700,"absMaxCoolSetpointLimit":4000,"pIHeatingDemand":0,"systemTypeConfig":0,"localTemperatureCalibration":0,"occupiedCoolingSetpoint":3500,"occupiedHeatingSetpoint":1900,"unoccupiedCoolingSetpoint":4000,"unoccupiedHeatingSetpoint":1700,"minHeatSetpointLimit":500,"maxHeatSetpointLimit":3000,"minCoolSetpointLimit":700,"maxCoolSetpointLimit":4000,"minSetpointDeadBand":25,"remoteSensing":2,"ctrlSeqeOfOper":2,"systemMode":4}},"hvacUserInterfaceCfg":{"dir":{"value":1},"attrs":{"tempDisplayMode":0,"keypadLockout":0,"programmingVisibility":0}},"msTemperatureMeasurement":{"dir":{"value":2},"attrs":{}}}}},"_id":"xsLNRH73hBUsQ2Zp"}

My question now is on which of those lines do I put the "modelId": "ST218", you mention in your email ???

-I stopped again zigbeetomqtt
-I tried adding it to the three lines
-Restarted zigbeemqtt
-Here is what I have in the log

zigbee2mqtt:info 2019-1-6 08:16:46 Currently 1 devices are joined:
zigbee2mqtt:info 2019-1-6 08:16:46 0xf8f005fffff89588 (0xf8f005fffff89588): unkown - undefined unknown (Router)

-I stopped again zigbeetomqtt looked into database.db now there was only 2 lines for id(2)
-Still, the device (0xf8f005fffff89588): unkown - undefined unknown (Router) in the log file

-I then stopped again the zigbeetomqtt
-I added the following in the device.js

// Stelpro
{
zigbeeModel: ['ST218'],
model: 'SORH',
vendor: 'Stelpro',
description: 'Thermostat integre zigbee Stelpro ',
supports: 'temperature',
fromZigbee: [],
toZigbee: [],
},

-I restarted the zigbetomqtt and now I have this in the log

1- zigbee2mqtt:info 2019-1-6 08:26:51 0xf8f005fffff89588 (0xf8f005fffff89588): SORH - Stelpro Thermostat integre zigbee Stelpro (Router) in the log

-Next step, I went to the thermostat and played with temperature and put it at 22 instead of 21
NOTHING HAPPENS IN THE LOG FILE

-My question now have I missed something somewhere ?
Thanks for any help

goldriver2 on 6 Jan 2019

hi
the last line is the more complete one.
I see another issue about Stelpro https://github.com/Koenkk/zigbee2mqtt/issues/497, please see the best modelId they put in place.

khzd on 8 Jan 2019

What do you mean the last line is the more complete one “nothing in the log “ ?

I have also seen the other thread about Stelpro, the thing is they have 2 thermostat, one that is standalone on the wall and the other is integrated to the heatbase, I am almost certain that this is why there are 2 modelId

Le 8 janv. 2019 à 08:43, Khaled notifications@github.com a écrit :

hi
the last line is the more complete one.
I see another issue about Stelpro, please see the best modelId they put in place.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

goldriver2 on 8 Jan 2019

hi
the last line in the DB is the more complete one, you may delete the first line about your device.

about 2 moedId, if you have only one, indeed you have only one record in the Db, so you may focus on only the las more complte line in the DB.
you have to add the modelId before manufacturerName, ie:
{"id":2,"type":"Router","ieeeAddr":"0xf8f005fffff89588","nwkAddr":54989,"modelId":"ST218", "manufId":4485,"manufName":"Stelpro\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","powerSource":"Mains (single phase)","epList":[25],"status":"online","joinTime":1546780137,"endpoints":{"25":{"profId":260,"epId":25,"devId":769,"inClusterList":[0,3,4,513,516],"outClusterList":[1026],"clusters":{"genBasic":{"dir":{"value":1},"attrs":{"zclVersion":1,"appVersion":104,"stackVersion":3,"hwVersion":1,"manufacturerName":"Stelpro\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","modelId":"ST218\u0000\u0000\u0000(\u0001](\u0001S\b\u0000\u0001X%\u0004\u0000��\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000","dateCode":"20170126 00111\u0000","powerSource":1}},"genIdentify":{"dir":{"value":1},"attrs":{"identifyTime":170,"identifyCommissionState":0}},"genGroups":{"dir":{"value":1},"attrs":{"nameSupport":0}},"hvacThermostat":{"dir":{"value":1},"attrs":{"16385":-32768,"16412":4,"localTemp":2150,"outdoorTemp":-32768,"ocupancy":1,"absMinHeatSetpointLimit":500,"absMaxHeatSetpointLimit":3000,"absMinCoolSetpointLimit":700,"absMaxCoolSetpointLimit":4000,"pIHeatingDemand":0,"systemTypeConfig":0,"localTemperatureCalibration":0,"occupiedCoolingSetpoint":3500,"occupiedHeatingSetpoint":1900,"unoccupiedCoolingSetpoint":4000,"unoccupiedHeatingSetpoint":1700,"minHeatSetpointLimit":500,"maxHeatSetpointLimit":3000,"minCoolSetpointLimit":700,"maxCoolSetpointLimit":4000,"minSetpointDeadBand":25,"remoteSensing":2,"ctrlSeqeOfOper":2,"systemMode":4}},"hvacUserInterfaceCfg":{"dir":{"value":1},"attrs":{"tempDisplayMode":0,"keypadLockout":0,"programmingVisibility":0}},"msTemperatureMeasurement":{"dir":{"value":2},"attrs":{}}}}},"_id":"xsLNRH73hBUsQ2Zp"}

cheers

khzd on 9 Jan 2019

👍1

Ok 2 thing:
1- I cleaned-up the database.db file and only kept the last line but when I stop/restart zigbee2mqtt lines are added everytime to the database.db file:

2- Even if i changed the modelId and moved it in front of the manufacturername exactly as you showed in your response, when I play with the thermostat, there is still nothing hapening in the log

goldriver2 on 9 Jan 2019

See my answer to this issue:

https://github.com/Koenkk/zigbee2mqtt/issues/844

henriz on 12 Jan 2019

I looked at the link you provided and implemented it BUT this does not give me more informations neither fix my issue. I already knew what my device ref was (0xf8f005fffff89588)

Looking at the line that was created in the database.db when pairing occured, I saw the following: "modelId":"ST218\u0000\u0000\u0000(\u0001](\u0001S\b\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/\u0000\u0002\u0000"

I tought that this whole line might be the modelId so I tried to enter this complete line of information in the device.js instead of just entering St218 but still no reaction in the log when I activate the thermostat temperature.

goldriver2 on 12 Jan 2019

Maybe you should look a bit better.

After adding your modelID ('ST218') you also have to remove all instances with your device address from database.db, configuration.yaml and state.json, and then repair.

As the device has now already been paired wrong, it's not re-pairing.

henriz on 12 Jan 2019

Ok, I made sure the modelId was created correctly in the device.js with ST218, I stopped zigbee2mqtt, I remove ALL reference to the 0xf8f005fffff89588 device in the database.db and configuration.yaml (state.json was empty) and Restarted zigbee2mqtt, I repaired and still:

zigbee2mqtt:info 2019-1-12 07:45:40 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"device_connected","message":"0xf8f005fffff89588"}'
zigbee2mqtt:warn 2019-1-12 07:45:40 Device with modelID 'undefined' is not supported.
zigbee2mqtt:warn 2019-1-12 07:45:40 device address '0xf8f005fffff89588'

here is my device.js setup:

{
zigbeeModel: ['ST218'],
model: 'ST218',
vendor: 'Stelpro',
description: 'Thermostat integre zigbee Stelpro ',
supports: 'temperature',
fromZigbee: [],
toZigbee: [],
},

goldriver2 on 12 Jan 2019

Then the modelid is not 'ST218'.

If this:
ST218\u0000\u0000\u0000(\u0001](\u0001S\b\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/\u0000\u0002\u000

is what you earlier found in the database.db file, then you have to enter that entire string as modelID.

Which is strange by the way, as \u0000 is equal to 'NULL', so it might be either that device reports a strange modelID, or zigbee2mqtt somehow extracts that modelID wrong.

Just copy whatever you are getting in your database.db as modelI, to the device.js model variable. In it's entirety.

henriz on 12 Jan 2019

entered the complete ST218...

here is bthe rersults when I repair:

zigbee2mqtt:info 2019-1-12 08:21:09 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"device_connected","message":"0xf8f005fffff89588"}'
zigbee2mqtt:warn 2019-1-12 08:21:09 Device with modelID 'undefined' is not supported.
zigbee2mqtt:warn 2019-1-12 08:21:09 device address '0xf8f005fffff89588'

goldriver2 on 12 Jan 2019

There's something going on with that device ID. I don't have the time right now, but some added logging on pairing would help to solve this. If the issue hasn't been solved by then, I'll look into it this evening. It's 14:34 over here now.

henriz on 12 Jan 2019

Ok I’ll continue my research and post my results before 18:00 your time

Bruno Lalongé
Envoyé de mon iPhone

Le 12 janv. 2019 à 08:34, henriz notifications@github.com a écrit :

There's something going on with that device ID. I don't have the time right now, but some added logging on pairing would help to solve this. If the issue hasn't been solved by then, I'll look into it this evening. It's 14:34 over here now.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

goldriver2 on 12 Jan 2019

To give you a pointer, those \u values stand for special characters. You have to find how to put those in a javascript string, and then put that in there.

(the double \ escapes the single )

henriz on 12 Jan 2019

Based on https://github.com/Koenkk/zigbee2mqtt/issues/421#issuecomment-425450869 you can just write \u0000... (see https://github.com/Koenkk/zigbee-shepherd-converters/pull/89/files#diff-6c9a6acf22f90d1c6e524d9f3c5c1745R82 ). So simple copy and paste should have worked ...

sehraf on 12 Jan 2019

There's also a / in there. Maybe that should have been escaped?

A better way would be to have zigbee2mqtt remove all non-standard ascii chars from the deviceid.

henriz on 12 Jan 2019

If the device id is just used for matching then this might be the easiest approach as long as there are no devices that differ only in weird uni-code characters. @Koenkk

sehraf on 12 Jan 2019

Ok first please bare with me as I am definitly not a programmer

While doing my test, everytime I erased any lines referencing to the device 0xf8f005fffff89588 in the database.db and in the configuration.yaml (there as never been any data in the state.json so no made were made to this file.

I also completely reset my Stelpro device to factory setting.

The first time I put my device in pairing mode, the zigbe2mqtt log never showed anything happening, I always need to stop zigbee on the Stelpro and then pair it again. Then only I can see the
zigbee2mqtt:info 2019-1-12 08:21:09 MQTT publish: topic 'zigbee2mqtt/bridge/log', payload '{"type":"device_connected","message":"0xf8f005fffff89588"}'
zigbee2mqtt:warn 2019-1-12 08:21:09 Device with modelID 'undefined' is not supported.
zigbee2mqtt:warn 2019-1-12 08:21:09 device address '0xf8f005fffff89588'

if i look at the database.db after this, there are 3 lines reffering to this device, the 2 first lines does not seem complete, only the third is complete.

Sometimes the modelId contains bizzare caracters: "modelId":"ST218\u0000\u0004\u0000��\u0001\u0015�\u0001\u0013\u000f\u0004\u0001\u0002R0n\u0004\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000

and sometimes not:
"modelId":"ST218\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/"

goldriver2 on 12 Jan 2019

I have a bad feeling about this. Why is the model id changing? It looks like the device is actually reading random memory. If this is true then the model id will always be random to a certain extend.
Counting bytes: it always sends 31 bytes as a model id. Looks like someone used 32 byte to store the model id but only set the first 5 or 6 :rofl: #highQualityProgramming

sehraf on 12 Jan 2019

👍1

However, if zigbee2mqtt would ditch al none 'a-z' and '0-9' chars, it would work.

henriz on 12 Jan 2019

While there are many devices that look like "<modelId>\0<random>" (trailing \0 from C strings) there are some that seem to have a byte model id "\u0000\u0002\u0000\u0004\u0012".
The question is: Are these the real ids that don't change? In the worst case there was exactly one user who has seen this id one time, added it and it was working for him, while it won't work a second time for anybody else.

sehraf on 12 Jan 2019

I would like to be of any help, unfortunatly I have no knowledge of programming but I can understand that it can be a headeach to program something for an unstable modelId !

goldriver2 on 12 Jan 2019

Maybe another workaround could be devised. You can't develop against unstable or changing ID's. And if there are devices that have a byte model ID, ditching all non-ascii chars won't work without breaking other stuff.

But.. how about making it possible to add exception devices based on the device address. Like a 'custom.db', 'custon.json' or 'custom.yaml' in which an end user can add the network ID and the desired ModelID?

Added advantage could be people can add unknow devices more easily. For instance, an RGB bulb will most likely just use the same code as a generic RGB bulb. Instead of then adding these to a .js file, one coud add it to the above mentioned file with a modelID which is known.

henriz on 12 Jan 2019

Just to confirm, I brought my RPI rigth nearby the Stelpro thermostat to make sure distance was not an issue and redid 5 pairing, here are the results:

"modelId":"ST218\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/"

"modelId":"ST218\u0000\u0000\u0000(\u0001]
(\u0001S\b\u0000\u0001X%\u0004\u0000��\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000"

"modelId":"ST218\u0000@\u0000�\u0000@\u0000��\u0000\u0000�\u0004\u0000��\u0001\u0015\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000"

"modelId":"ST218\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0001\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000"

"modelId":"ST218\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/\u0000@\u0000�\u0000@\u0000"

goldriver2 on 12 Jan 2019

Thanks @goldriver2 for doing some testing. I think the easiest way is to cut any model id by the first null and add some byte model id workaround for the few devices that need it.
But lets first wait for @Koenkk 's opinion.

sehraf on 12 Jan 2019

I would propose the following:

First a search with the normal modal ID will be done (so e.g. ST218\u0000\u0000\u0000\u0000\u0000\u0000\u0007\u0000\u0000\u0000\u0000\u0000\u0007\u0001,c\u0001\u0001/\u0000@\u0000�\u0000@\u0000
If no device is found, search again while stripping everything after the first '\u'.

Koenkk on 13 Jan 2019

:+1:
What will be the policy with (new) model ids containing \uXXXX?
Can ids like lumi.sensor_86sw1\u0000lube shortened to lumi.sensor_86sw1?

sehraf on 13 Jan 2019

Yes, but the above solution is backwards compatible so there is no need to.

Let's first check if it works, I posted some code here to test this: https://github.com/Koenkk/zigbee2mqtt/issues/833#issuecomment-453862582

Koenkk on 13 Jan 2019

How about the other way around. First search for the complete ID, and if that's not found, take the list of devices and see if the first part of the device string matches.

So, IE, if you have something like ST218\u0000... and so forth. You first use the current method, which won't find it. And then you turn it around an cydle the device array from devices.js and see if the model matches the first part of the searched string.

In devices you would then have the normal 'ST218' ID, so it will then look if the first 5 characters of the modelI it got, matches that.

henriz on 13 Jan 2019

I will be more than happy to test the dev branch, one thing before I proceed, I have find out how to clone from dev branch but I have no idea if I have to do a "uninstall" before ugrading and how to do it ? npm uninstall ???

goldriver2 on 13 Jan 2019

I've updated the dev branch to strip the null characters.

So ST218 can be used as the zigbeeModel now.

@goldriver2 after switching to the dev branch, do a rm -rf node_modules && npm install

Koenkk on 14 Jan 2019

❤1

Ok lets recap,

I have installed the new zigbeetomqtt
- removed the /opt/zigbee2mqtt directory
- sudo git clone --branch dev https://github.com/Koenkk/zigbee2mqtt.git /opt/zigbee2mqtt
- reconfigured the device.js adding sthe stelpro:
// Stelpro model ST218
{
zigbeeModel: ['ST218'],
odel: 'ST218',
vendor: 'Stelpro',
description: 'Stelpro ST218',
supports: 'Thermostat temperature and outside temperature',
fromZigbee: [],
toZigbee: [],
},
- restarted zigbeetomqtt

-I paired the device, in the log files I still had "Unsuported device"

stopped zigbetomqtt

I then remembered that @Koenkk told me I had to edit the database.db to move the content of the "modelId" before the "manufName", once done, restarted the zigbetomqtt since the pairing message received from the device was not in the order expected.

Now I have
zigbee2mqtt:info 2019-1-15 05:49:37 0xf8f005fffff89588 (0xf8f005fffff89588): ST218 - Stelpro Stelpro ST218 (Router)

But when I change the temperature on the thermostat, nothing happens in the log

would I be right to think that the "temperature" change message from the thermostat also have the "modelId" not at the same place in the transmited zigbee message and the zigbe2mqtt does not show anything in the log because it does not recognise it ?

goldriver2 on 15 Jan 2019

Hi
Good progress for modelid challenge :)
Now you can focus on the second one :
fromZigbee: [],
toZigbee: [],

You have to fill the [] with the good proc. See thermostat implementations
Bon courage

khzd on 15 Jan 2019

I am Back to where I left a few weeks ago for a knee surgery, please bare with me as am am still not a programmer or an IT guy

As mentionned before, I have been able to pair the Stelpro ST218 with the plugin, now, according to the GITHUB instrcution, I am trying to get some feed back from the thermostat by playing with the down and up button but unfortunatly nothing happens in the log.

looking again at the documentation, it is mentionned "in case your device is not reporting anything, it could be that this device requires additional configuration. " I have looked at the exemples the page links to but I seriously have NO CLUE of where to start and what I would need to add in a "configuiration" section.

I found this exemple for an eCozy thermostat but how the hell can I find all parameters for the specific STelpro ????

help please

would anything from this Stelpro Repo help ?
https://github.com/stelpro/Ki-ZigBee-Thermostat

// eCozy
{
zigbeeModel: ['Thermostat'],
model: '1TST-EU',
vendor: 'eCozy',
description: 'Smart heating thermostat',
supports: 'temperature, occupancy, un-/occupied heating, schedule',
fromZigbee: [
fz.ignore_basic_change, fz.generic_battery_voltage,
fz.thermostat_att_report, fz.thermostat_dev_change,
],
toZigbee: [
tz.factory_reset, tz.thermostat_local_temperature, tz.thermostat_local_temperature_calibration,
tz.thermostat_occupancy, tz.thermostat_occupied_heating_setpoint,
tz.thermostat_unoccupied_heating_setpoint, tz.thermostat_setpoint_raise_lower,
tz.thermostat_remote_sensing, tz.thermostat_control_sequence_of_operation, tz.thermostat_system_mode,
tz.thermostat_weekly_schedule, tz.thermostat_clear_weekly_schedule, tz.thermostat_weekly_schedule_rsp,
tz.thermostat_relay_status_log, tz.thermostat_relay_status_log_rsp,
],
configure: (ieeeAddr, shepherd, coordinator, callback) => {
const device = shepherd.find(ieeeAddr, 3);
const actions = [
// from https://github.com/ckpt-martin/Hubitat/blob/master/eCozy/eCozy-ZigBee-Thermostat-Driver.groovy
(cb) => device.bind('genBasic', coordinator, cb),
(cb) => device.bind('genPowerCfg', coordinator, cb),
(cb) => device.bind('genIdentify', coordinator, cb),
(cb) => device.bind('genTime', coordinator, cb),
(cb) => device.bind('genPollCtrl', coordinator, cb),
(cb) => device.bind('hvacThermostat', coordinator, cb),
(cb) => device.bind('hvacUserInterfaceCfg', coordinator, cb),
(cb) => device.report('hvacThermostat', 'localTemp', 5, 30, 0, cb),
];

        execute(device, actions, callback);
    },
},

goldriver2 on 15 Feb 2019

made some progress, I have been able to define a device.js file that now provides me at least the local temperature.

I am now stuck where if I change the temperature on the thermostat, nothing is returned to the zigbee2mqtt

{
zigbeeModel: ['ST218'],
model: 'ST218',
vendor: 'Stelpro',
description: 'Thermostat ',
supports: 'temperature and humidity',
fromZigbee: [
fz.ignore_basic_change, fz.generic_battery_voltage,
fz.thermostat_att_report, fz.thermostat_dev_change,
],
toZigbee: [
tz.factory_reset, tz.thermostat_local_temperature, tz.thermostat_local_temperature_calibration,
tz.thermostat_occupancy, tz.thermostat_occupied_heating_setpoint,
tz.thermostat_unoccupied_heating_setpoint, tz.thermostat_setpoint_raise_lower,
tz.thermostat_remote_sensing, tz.thermostat_control_sequence_of_operation, tz.thermostat_system_mode,
tz.thermostat_weekly_schedule, tz.thermostat_clear_weekly_schedule, tz.thermostat_weekly_schedule_rsp,
tz.thermostat_relay_status_log, tz.thermostat_relay_status_log_rsp,
],
configure: (ieeeAddr, shepherd, coordinator, callback) => {
const device = shepherd.find(ieeeAddr, 25);
const actions = [
(cb) => device.bind('genBasic', coordinator, cb),
(cb) => device.bind('genIdentify', coordinator, cb),
(cb) => device.bind('genGroups', coordinator, cb),
(cb) => device.bind('hvacThermostat', coordinator, cb),
(cb) => device.bind('hvacUserInterfaceCfg', coordinator, cb),
(cb) => device.bind('msTemperatureMeasurement', coordinator, cb),
(cb) => device.report('hvacThermostat', 'localTemp', 300, 3600, 0, cb),
];

        execute(device, actions, callback); 
     },

goldriver2 on 16 Feb 2019

I have no clue as to how to do a PR to add something to GITHUB but for anyone interested, here is the changes I added to my device.js to get it to work:

const devices = [
// Stelpro Orleans baseboard thermostat
{
zigbeeModel: ['ST218'],
model: 'ST218',
vendor: 'Stelpro',
description: 'Baseboard integrated zigbee Thermostat ',
supports: 'temperature ',
fromZigbee: [
fz.thermostat_att_report, fz.thermostat_dev_change,
],
toZigbee: [
tz.thermostat_local_temperature, tz.thermostat_occupied_heating_setpoint,
tz.thermostat_pi_heating_demand,
],
configure: (ieeeAddr, shepherd, coordinator, callback) => {
const device = shepherd.find(ieeeAddr, 25);
const actions = [
(cb) => device.bind('genBasic', coordinator, cb),
(cb) => device.bind('genIdentify', coordinator, cb),
(cb) => device.bind('genGroups', coordinator, cb),
(cb) => device.bind('hvacThermostat', coordinator, cb),
(cb) => device.bind('hvacUserInterfaceCfg', coordinator, cb),
(cb) => device.bind('msTemperatureMeasurement', coordinator, cb),
(cb) => device.report('hvacThermostat', 'localTemp', 300, 3600, 0, cb),
];
execute(device, actions, callback);
},
},