Zeroclickinfo-goodies: Conversions Suggestion: (PRESSURE) - Add Missing Units

[pjhampton]

Problem

We recently migrated the conversions API into an interactive UI. However, some units were ditched for various reasons and the legacy code didn't necessarily support all of the units that were desired from users. This is a good opportunity to take the lead in the search engine conversions game.

Solution

1. Add some front-end tests to spec/conversions_spec.js. This will test the custom units

2. Add some back-end tests to t/Conversions.t. This will test the triggering.

3. Update the triggering in triggers.yml

4. Add the custom unit to Conversions.js (Line 45) and add it to the Units Object in Conversions.js (Line 166)

UNITS

• [ ] Barye
• [ ] Millipascal
• [ ] Hectopascal
• [ ] Kilopascal
• [ ] Megapascal
• [ ] Standard Atmosphere
• [ ] Technical Atmosphere
• [ ] Millibar
• [ ] Centibar
• [ ] Decibar
• [ ] Kilobar
• [ ] Megabar
• [ ] Gigabar

People to notify

Get Started

• [x] 1) Claim this issue by commenting below
• [x] 2) Review our Contributing Guide
• [x] 3) Set up your development environment, and fork this repository
• [x] 4) Create a Pull Request

Resources

• Join DuckDuckHack Slack to ask questions
• Join the DuckDuckHack Forum to discuss project planning and Instant Answer metrics
• Read the DuckDuckHack Documentation for technical help

Instant Answer Page: https://duck.co/ia/view/conversions

[ryr3]

Hey! I'd like to work on this. Please assign me.

[pjhampton]

Awesome! Thanks so much @ryr3
We'll get you added to the DDG github organization soon. In the meantime, feel free to get started and reach out here or on slack if you need help / have questions... 👍

[pjhampton]

Assigned 👍

[pjhampton]

Hey @ryr3

Just to let you know, some of these have come in and have been merged. I'm linking to them just incase you need some inspiration or help 👍

• https://github.com/duckduckgo/zeroclickinfo-goodies/pull/4196
• https://github.com/duckduckgo/zeroclickinfo-goodies/pull/4195
• https://github.com/duckduckgo/zeroclickinfo-goodies/pull/4197

[ryr3]

Thanks! I'm done with most of the work, except for the Perl testing. Just wanted to make sure of this, it is enough to test each customUnit once? I mean, for example, there's no need to test barye with all of the other units, just one other customUnit, and it is enough to test only the customUnits that I've added.
Thanks in advance! :smiley:

[pjhampton]

Hey @ryr3,

Yeah, you definitely don't need to test against every unit. I try to kill two birds with one stone in these cases, such as 10 Kilopascal to metapascal. Hope that helps!