Zeroclickinfo-goodies: HelpLine: Formatting

[spagy]

Could the formatting be improved so that different numbers are on different lines?
At the moment they all seem to run into one another.

It would also be nice to have a description of what each number is for if that's possible.

---

IA Page: http://duck.co/ia/view/help_line
Maintainer: @conorfl

[moollaza]

@Spagy thanks for reporting. This IA should likely be ported to use the full templates to take advantage of the List Template.

Then it could produce a table where each row would contain a phone number.

[moollaza]

Details about how to convert a Goodie to full templates can be found in #2767

[NaveenKarippai]

@moollaza could you please assign this issue to me. I'm interested to work on it.

[GuiltyDolphin]

@NaveenKarippai It looks like you aren't in the contributors group? @moollaza I think an invite is in order.

[NaveenKarippai]

@GuiltyDolphin Thanks. I'd be glad to get an invite in contributors group.

UPDATE: I noticed that _help_line_ IA is not triggered for some reason (tried multiple locations)? could you please check the same.

[GuiltyDolphin]

@NaveenKarippai Seems fine for me https://duckduckgo.com/?q=suicide+hotline&t=ffab&ia=answer

[NaveenKarippai]

@GuiltyDolphin

SECOND_UPDATE: I used vpn and it's triggered fine.

[tagawa]

Sorry for the delay @NaveenKarippai. I sent you an invitation to join the contributor group. If you accept that then we can assign issues to you.

[NaveenKarippai]

@tagawa no worries! And, thanks for the invite :+1:

[NaveenKarippai]

ToDo:

• [ ] refactor /adapt test suite

[GuiltyDolphin]

@NaveenKarippai Rather than going for a bulleted list, it may be worth doing a KV list seeing as there is more info in the YAML than just the phone number (you may wish to add a name for each as well).

[NaveenKarippai]

@GuiltyDolphin could you please post an example of KV list (appearance) as I'm not sure about it.
Regarding _more info_ on list view, are you refering to web data field on yml file?
And, how would you ask to add names - use _website name_?

[GuiltyDolphin]

@NaveenKarippai Yeah, I was thinking the website names (/ company names if available) would be best - then you could KV the name with phone number.

Here's a link to a query that shows key values: https://duckduckgo.com/?q=abc+%3D~+%2F%28%3F%3Cfirst%3Ea%29%28%3F%3Csecond%3Eb%29%28%3F%3Cthird%3Ec%29%2F&ia=answer

[NaveenKarippai]

@GuiltyDolphin Thanks. It seems that I should ditch custom handlebars template and go for record sub-template to get KV list.

double-checking; Should I be adding website names explicitly on yml dat- For e.g., web: http://www.lifeline.org.au/Get-Help/I-Need-Help-Now should have name: lifeline data added and show namefield as key on list?

[GuiltyDolphin]

@NaveenKarippai Yeah, basically - but find out the actual organization name (which may or may not be the same as the website name).

[NaveenKarippai]

@GuiltyDolphin switched to KV list by using content sub-template! Could you please review the changeset.

FYI: The longer names (key-data field) are being wrapped off on list view.

[moollaza]

Could you please review the changeset.

@NaveenKarippai please make a PR so we can review

[NaveenKarippai]

@moollaza I have referenced open PR on issue tracker (if you please scroll up, it should be visible). I still need to refactor/adapt test suite. working on it soon :small_blue_diamond:

PR: https://github.com/duckduckgo/zeroclickinfo-goodies/pull/3096

[mintsoft]

Fixed in : https://github.com/duckduckgo/zeroclickinfo-goodies/pull/3096