Zeroclickinfo-goodies: Regexp: Improve display for mobile devices

Created on 27 Feb 2016  路  13Comments  路  Source: duckduckgo/zeroclickinfo-goodies

Unfortunately in getting Regexp to display nicely on full-width screens, it seems the mobile display has been reduced:

screenshot from 2016-02-27 12 16 30

VS

screenshot from 2016-02-27 12 16 37

What needs to be done:

  • Fix the mobile display so that both the pattern names _and_ matches consistently display well.
  • Ensure the full-screen display is robust and won't be messed up by long queries.

IA Page: https://duck.co/ia/view/regexp

Design Improvement Low-Hanging Fruit Medium

Most helpful comment

@moollaza I'll make the changes and create a new PR.

All 13 comments

Oh hey I'm the maintainer!

@jagtalon Apparently yes! Any thoughts?

Uhm, that it should be fixed? Hahaha

I kid. I'll look into it

We can probably reduce the subtitle text to "Matching /.../ on $text"

@GuiltyDolphin @jagtalon If there has been no update on this issue so far, I'd be interested to try some CSS magic here.

@NaveenKarippai Go for it - I'm in need of a CSS magician.

Bumping this issue.

Is there anything else that needs to be done for this to be finished? I'm very adept at CSS, should it need any finishing touches.
@GuiltyDolphin, @jagtalon, & @NaveenKarippai

@holtjohnson The PR is over on https://github.com/duckduckgo/zeroclickinfo-goodies/pull/3154 if you wanted to take a look.

@moollaza What's the status with the PR? Are there any outstanding issues?

@moollaza What's the status with the PR? Are there any outstanding issues?

Yes, the PR should not add any media queries. If we simply remove the set width, this problem should mostly be fixed. There's a separate issue that needs to be fixed internally with our chomp() function

@moollaza I'll make the changes and create a new PR.

@holtjohnson thanks a lot!

Made the changes and created a PR.
@moollaza & @GuiltyDolphin

Fixed in #2643

Was this page helpful?
0 / 5 - 0 ratings