Zebra: [BUG] Can't remove Essential packages

[worldlydev]

Describe the bug
A clear and concise description of what the bug is.

Title says it all. Zebra can't uninstall Saily Store while Sileo can do so just fine.

Repo:
http://ouop.github.io/

To Reproduce
Steps to reproduce the behavior:

^

Expected behavior
A clear and concise description of what you expected to happen.

I expect the tweak to be uninstalled.

Screenshots
If applicable, add screenshots to help explain your problem.

Screen recording:
https://imgur.com/a/vWeRd40

Device Information (please complete the following information):

• iOS Version [e.g. 12.1.2 or 10.3.3]: 12.1.1 b3
• Zebra Version [e.g. 1.0\~beta1 or beta1]:
  1.0~Beta 27-1
  
  
  
  • Device Type [e.g. iPhone or iPad]: iPhone Xs
  
  
• Jailbreak Type [e.g. unc0ver, Chimera, checkra1n, etc.]: Chimera

Crash Log or System Log
Please provide a Crash Log to help us solve the issue.

N/A

Additional context
Add any other context about the problem here.

N/A

[worldlydev]

Update: I first noticed this issue months ago when I was localizing Saily. I forgot to report it then and it seems it is still not possible.

[wstyres]

This looks to be related to #568 with removing essential packages. I will try to reproduce when I get a chance.

[wstyres]

Currently working on the UI for this. Packages with Essential: Yes or Priority: Required will now have some extra information before you remove them as removing them is a potentially harmful action.

It _should_ work as of 2c2b3f3ad23bec4c4e3fb1f6331fabce07522f7c but I'm unable to verify it right now. When I can check on it I will report back. If there are any UI changes you'd like to suggest I'm open to them.

[wstyres]

In the case of #568, I did find that sedfix was an Essential package which was possibly why it was not getting removed. This should be truly fixed for the next beta but I'm unable to confirm until I test.

[worldlydev]

I actually do have a suggestion for the UI. Maybe make "ok" red instead of "remove from queue" as removing the package from the queue is the safe option.

[wstyres]

Slightly modified as per @worldlydev's suggestion.

[wstyres]

I'm able to uninstall Saily and sedfix after the fix in 2c2b3f3, it will be available in the next beta.

[MustyAslan99]

Hey by the way you mentioned "sedfix" so what package is that?

[wstyres]

It is an add-on called "CracksCompatibility" from some piracy repo. For some reason it is marked as essential.

[MustyAslan99]

Oh yeah I remember getting that when I "Upgrade all" in Cydia or Zebra it auto adds it but it's not in changes and it can easy be removed... But it's really annoying so I had to remove the repo..

[MustyAslan99]

It's from pulandres repo.. which most or all users claims it's trusted and doesn't have malware in its cracks 🤷🏻‍♂️

[wstyres]

Not saying that it contains malware, just pointing out that it is marked as essential and thus cannot be removed.

[MustyAslan99]

Also just found that for my issue and on this issue was caused by him maybe? And there's a solution if it's fine but idk? https://twitter.com/pulandres_/status/1193585970895114242?s=21

[MustyAslan99]

Not saying that it contains malware

Well I didn't say you said it.. I mean like that could cause this problems? Just trying to figure it out and help out

[worldlydev]

Can confirm that the fix is functioning in beta 28-1