Yuzu: Compilation error: cubeb/cubeb.h: No such file or directory

[KAMiKAZOW]

Checked out source tree with all submodules.
Tried both -DENABLE_CUBEB on and off – no difference.

In all cases:

[  754s] In file included from /home/abuild/rpmbuild/BUILD/yuzu-0.0.20180803+git.c1d54f4a/src/audio_core/cubeb_sink.cpp:8:
[  754s] /home/abuild/rpmbuild/BUILD/yuzu-0.0.20180803+git.c1d54f4a/src/./audio_core/cubeb_sink.h:10:10: fatal error: cubeb/cubeb.h: No such file or directory
[  754s]  #include <cubeb/cubeb.h>
[  754s]           ^~~~~~~~~~~~~~~
[  754s] compilation terminated.

If your require more info, you can find everything here: https://build.opensuse.org/package/show/home:KAMiKAZOW:Emulators/yuzu

[mailwl]

git submodule update --init --recursive ?

[KAMiKAZOW]

git submodule update --init --recursive ?

https://build.opensuse.org/package/view_file/home:KAMiKAZOW:Emulators/yuzu/_service?expand=1
<param name="submodules">enable</param> !

[hcorion]

that doesn't do it recursively though?

[jroweboy]

@hcorion cubeb is a top level submodule and doesn't needed recursive. additionally i believe we removed any recursive submodule requirements a while ago

[hcorion]

cubeb requires the sanitizers-cmake submodule to be inited, and optionally the googletest submodule, if you want to build it with tests.

[KAMiKAZOW]

Citra and Dolphin both have cubeb and the compile fine in OBS.

The cmake command is in https://build.opensuse.org/package/view_file/home:KAMiKAZOW:Emulators/yuzu/yuzu.spec?expand=1 between lines 82 and 89.

[jroweboy]

hashtag blame bunnei

https://github.com/yuzu-emu/yuzu/blob/83ef37ca37e052f4293c7693766f36f24754388e/src/audio_core/CMakeLists.txt#L7

should look like this instead

https://github.com/citra-emu/citra/blob/0233f3286cdf20550f30f1071d7d70e753c83c5e/src/audio_core/CMakeLists.txt#L27

(where you conditionally add cubeb to the build if its enabled)

free PR to someone who is available right now ;)

(note that in the dolphin build configuration they turn off cubeb, and you'll need to do the same i'm guessing since you don't have recursive submodule support)

[KAMiKAZOW]

where you conditionally add cubeb to the build if its enabled

Which wouldn't change the fact that cubeb.h cannot be found if enabled. It only will really disable cubeb if the CMake parameter says to disable it.

Just download the generated source package yourself and you'll see that externals/cubeb/include/cubeb/cubeb.h is there!

free PR to someone who is available right now ;)

Doing it right now but disabling cubeb just works around the problem that build process can't find the file even though it's there.

[GDhex12]

Is this issue still relevant?

[KAMiKAZOW]

Works now