Yaru: drag-handles aren't visible in dark theme

Created on 2 Feb 2020  ·  11Comments  ·  Source: ubuntu/yaru

I had some good guidance, but I simply couldn't fix this 😭

I tried a bounch of variations of scrolledwindow viewport hdycolumn image.drag-handle

image

image

gtk3

Most helpful comment

I can do that

All 11 comments

Consider it might not work out of gtk inspector, let me have a try ;)

On Sun, 2 Feb 2020, 5:19 pm MadsRH, notifications@github.com wrote:

I had some good guidance, but I simply couldn't fix this 😭

I tried a bounch of variations of scrolledwindow viewport hdycolumn
image.drag-handle

[image: image]
https://user-images.githubusercontent.com/3986894/73611235-1412f900-45e0-11ea-97bf-87bea77d6499.png

[image: image]
https://user-images.githubusercontent.com/3986894/73611239-20975180-45e0-11ea-9d68-3454f841544d.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/1847?email_source=notifications&email_token=AAWAAHV7IFLCK3N26CMUXUTRA3XAHA5CNFSM4KO2SIN2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKNMGIQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWAAHTSYMDFKQBAMTCQPFDRA3XAHANCNFSM4KO2SINQ
.

Ahh, it was just as an example. I did added it in tweaks and build it 😔

It looks like they style this themselves

https://gitlab.gnome.org/GNOME/gnome-control-center/blob/master/shell/style.css#L2

If this CSS file gets loaded after the global theme then you should file a bug on their repo I guess
(Tip: don't use yaru screenshots :dancing_men: )

Ahh, it was just as an example. I did added it in tweaks and build it pensive

Yes, what @Feichtmeier said is what I meant. GtkInspector changes are always applied after any other CSS, so they always work. Out of gtk inspector, instead, it's the app's CSS to be applied last, so it overwrites anything we put in our CSS

The next step could be to double check whether in Adwaita dark the problem is the same, if that so they would probably be more keen to change it

Good thinking! and it exist in Adwaita as well. They would probably prefer a patch rather than a bug report. Would any of you mind doing that?

image

I can do that

The best I could do so far was to open a ticket, since there is a known problem that prevents me to build Settings with gnome-builder

Closing this since it is to be solved upstream first

This is not reproducible in both fedora32 and 20.04 btw :)
image

Nice, must be fixed upstream 👍

Was this page helpful?
0 / 5 - 0 ratings

Related issues

snydox picture snydox  ·  3Comments

sicklylife-jp picture sicklylife-jp  ·  3Comments

Feichtmeier picture Feichtmeier  ·  3Comments

pojntfx picture pojntfx  ·  3Comments

8none1 picture 8none1  ·  3Comments