The icon for vs code (oss version - bottom one before the applications grid icon in the screenshot) is too large as compared to other yaru-style icons. I was wondering whether you would be interested in having a go at it. There are so many users of this editor - this will be highly visible.

Hi, sorry we don't change third party app icons (except pre installed app icons where we asked the developers)
Especially not from those big players like Firefox, Google, Microsoft and so on. Otherwise we'll go to branding hell :) closing this, thanks for contributing
Hey @coxackie, do you know if the maintainer is interested in a Yaru icon for this? We have designed only gnome default app icons and for the others we seek maintainers' permission and involvement
Was it supposed to be like this ? Adding a background is bad ?

It is not really the look of the icon, but the approach. We prefer to involve the maintainers as good manners :)
They might not like how the icon look like or just don't want to change it for branding or preference
@clobrano the "maintainer" is Microsoft - I am not entirely sure how easy it would be to get them involved. Otherwise, something like what @meetdilip suggests is not bad. There is immediate branding recognition, but also making the icon more in line with the others. More like "slight shrinkage".
This is the same discussion we had in the past about Firefox.
Apologies - I was not around back then for such discussion. Presumably the Firefox icon would be of the same size and shape as for Chromium and Spotify in my screenshot. These do not look so way off (size-wise) as Code. But, anyway, all this is null and void - I understand your approach to respect (as well as avoid issues with) branding.
Apologies - I was not around back then for such discussion.
I did not mean you should know it already, sorry, just that our current
approach has been tested on a similar case. Thanks for the support and
please keep report any issue you think will make Yaru better.
On Tue, 28 Jan 2020 at 15:02, Kostas Kardaras notifications@github.com
wrote:
Apologies - I was not around back then for such discussion. Presumably the
Firefox icon would be of the same size and shape as for Chromium and
Spotify in my screenshot. These do not look so way off (size-wise) as Code.
But, anyway, all this is null and void - I understand your approach to
respect (as well as avoid issues with) branding.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ubuntu/yaru/issues/1816?email_source=notifications&email_token=AAWAAHV5FUNLTSRC36YGY43RAA3I5A5CNFSM4KMFCENKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDM4JI#issuecomment-579259941,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWAAHRWHYZQAV32DHS6D4DRAA3I5ANCNFSM4KMFCENA
.
@clobrano Sorry for coming back to this, but I realised that Code - OSS is open source, while VS code is the Microsoft product; see:
https://github.com/microsoft/vscode/wiki/Differences-between-the-repository-and-Visual-Studio-Code
Distros like Arch package Code - OSS, which should be free of any Microsoft licencing, etc. I think that, as long as there is no icon for Microsoft VS Code, it should be OK (legally).
Could you maybe reconsider? Especially since an attempts has been made previously by @meetdilip.
Hi @coxackie, it was not a problem of licensing, but of being a third-party application + not installed by default. If there is any interest from them to have a Yaru icon, we could have a go.
Thanks, @clobrano, but in this case I am not sure who "them" would be that needs to be consulted. It is not Microsoft per-se, as this is an OSS build of the repo, not Microsoft's VS Code. Specifically, I am using this package.
Answering to the initial issue report, I am not sure if I can follow. I think the vscode icon looks quiet fancy along other icons and also along yaru icons

What is code OSS?
I am not talking about vscode exactly; code - oss is an "open source software" build, directly from the repo. You can see the icon below - it is the last blue one with white lines.

lol this is indeed butt ugly :D
Wouldn't it be cool if we would rather get our icon crew to contribute an icon to them?
@Feichtmeier that would be amazing, although I am not sure how receptive they might be at including an icon with specific guidelines, as Yaru tries. For reference, here is what Papirus has done:

All these correspond to a different build of code - it is the first one I am talking about. (Obviously, I am not leaving this here for you to "take inspiration", but just to show that Papirus also has a candidate that follows their guidelines.)
@Feichtmeier @clobrano This whole discussion is also making me realise that there is no obvious way for requesting icons. I understand that you want to get the OK from developers, but I think in this case there should be a way to do this seamlessly for anyone who wants to request an icon. For example, a centralised webpage of some sort that we can direct authors of packages to see the yaru style, and give consent that they are OK with yaru to implement an icon. It would further increase your visibility in time, and developers would potentially request it themselves. At the end of the day, everyone would like to see an nice icon in Ubuntu for their app.
If you think this is a reasonable idea that should be discussed, I would like to open a new issue so other parts of the community can give their feedback.
Most helpful comment
Hi @coxackie, it was not a problem of licensing, but of being a third-party application + not installed by default. If there is any interest from them to have a Yaru icon, we could have a go.