Yaru: Remove hardcoded colors from Software Center

[madsrh]

Seems like there's no way we can change these hardcoded colors. Would fixing this upstream be considered low hanging fruit for the desktop-team @flexiondotorg?

• Review stars
• Checkmark for installed applications
• Progressbars

Here's the mockup from https://github.com/ubuntu/yaru/issues/226

[Feichtmeier]

Here is the old upstream issue for this, still not closed:

https://gitlab.gnome.org/GNOME/gnome-software/issues/553

But it only contains:

• request $success_color or $suggested_bg_color for the counters and the checkmarks
• $progress_bg_color for the progress bars

BUT we firstly need to get those two colors into the public colors upstream and in yaru before this works
https://gitlab.gnome.org/GNOME/gnome-software/issues/553
https://github.com/ubuntu/yaru/blob/master/gtk/src/default/gtk-3.20/_colors-public.scss

Edit:
HA! Never mind... $success_color is already exported:
https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L84

So we only need to get $progress_bg_color into the public colors =) And then change it in gnome-software

For the stars, just the fg_color is totally fine:
https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/theme/Adwaita/_colors-public.scss#L10

[Feichtmeier]

Good news :tada:

Robert applied my patch really fast https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1862056

Now the bonus work is to get this into upstream + we can now remove the "box-shadow" hack for the .installed-icon from _aps.scss

[clobrano]

Awsome!