Yaru: Missing selected item on listbox in popover

[Exalm]

Expected Behavior

Actual Behavior

The item only has selected color in backdrop window.

Steps to Reproduce the Problem

1. Run a Nintendo DS game in GNOME Games
2. Open screen layout selector popover

Specifications

The version: whatever org.gtk.Gtk3theme.Yaru is on Flathub.

The widget layout: https://gitlab.gnome.org/GNOME/gnome-games/blob/master/plugins/nintendo-ds/data/ui/nintendo-ds-layout-switcher.ui https://gitlab.gnome.org/GNOME/gnome-games/blob/master/plugins/nintendo-ds/data/ui/nintendo-ds-layout-item.ui

Some more details:

Software that presents the issue:

• Name: gnome-games
• Version: nightly builds

[clobrano]

Hi @Exalm, thanks a lot!

[clobrano]

The version: whatever org.gtk.Gtk3theme.Yaru is on Flathub.

From the pictures, it looks like the app forces the dark version, is that so?

[Exalm]

From the pictures, it looks like the app forces the dark version, is that so?

Yes.

[clobrano]

Alright, so we have a problem. The flathub repo is https://github.com/flathub/org.gtk.Gtk3theme.Yaru-dark and the maintainer is vanished. There is also an old PR still waiting to be accepted

[Exalm]

No, it's not. I don't have org.gtk.Gtk3theme.Yaru-dark here, it's org.gtk.Gtk3theme.Yaru, dark variant.

[clobrano]

Okay, so, my understanding of flatpak-ed applications is that org.gtk.Gtk3theme.Yaru-dark should be picked up. I don't understand how org.gtk.Gtk3theme.Yaru could serve the dark variant (and this might even be the actual problem, since Yaru is the light variant).

I do have to update org.gtk.Gtk3theme.Yaru as well (this is my fault), but I expect org.gtk.Gtk3theme.Yaru-dark to be used here

[Exalm]

I don't understand how org.gtk.Gtk3theme.Yaru could serve the dark variant

gtk-dark.css. That is what all dark apps use, i.e. that's what GTK uses if gtk_application_prefer_dark_theme is true. Yaru-dark is a version where gtk.css and gtk-dark.css both point to dark variant.

In other words, Yaru:dark, not Yaru-dark.

[clobrano]

Is it the same for Adwaita? Is it not Adwayta-dark used in case of prefer dark theme is true?

[Exalm]

Of course. In fact, dark variants existed long before Adwaita-dark.

Literally, all the app does is to set gtk_application_prefer_dark_theme to true, then GTK uses dark variant.

[clobrano]

I see, thanks then

[Exalm]

https://developer.gnome.org/gtk3/3.2/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme

[Feichtmeier]

It's the jet popover wildcard :/
Which doesn't hit the backdrop, thus selection works there

[Feichtmeier]

Hi @Exalm I do not have any Nitendo game isos? at hand
Could you be so kind and try this branch?
https://github.com/ubuntu/yaru/tree/GtkTheme_killjetpopovers
Or give me a tip how to fake a nintendo game?

[Exalm]

@Feichtmeier https://www.zophar.net/pdroms/nintendods.html there are some public domain roms here. For example, https://www.zophar.net/pdroms/nintendods/powder-107.html run the .nds file there with the app.

[Feichtmeier]

@Exalm thanks for the link
any other thing i need to install?

[Exalm]

Ah, I guess Ubuntu doesn't package the necessary core? We only recommend to use flatpak, and the switcher was added after 3.32 anyway, so use https://gitlab.gnome.org/GNOME/gnome-games/-/jobs/320528/artifacts/raw/gnome-games-git.flatpak

Edit:

Version: nightly builds

[Feichtmeier]

right! flatpak :S But okay - I am installing that

[Exalm]

Well, you can build the latest retro-gtk, libmanette, libhandy and gnome-games on Ubuntu without Flatpak. If desmume2015 core is packaged, it will work. If not, then not :p

Not having the cores is one of the reason we only support Flatpak. Ubuntu does build some of them, but not all of them, and doesn't include metadaat for some, so it's really a guesswork if a particular platform works or not, while with Flatpak we just bundle the well-working cores and can be sure that the games run out of the box.

[Feichtmeier]

how can I switch the channel to nightly/edge? my god cant't you make a snap? :dancer:

[Exalm]

See the link above, that is the current master branch bundle. You should be able to just install that file. Nightlies are normally in gnome-apps-nightly remote, but looks they haven't been built since that rsvg incident.

[Feichtmeier]

@Exalm please test it if you have time, should be fixed now