Yaru: Gtk2-light : fixed two issues

Created on 28 Sep 2018  路  13Comments  路  Source: ubuntu/yaru

  1. Treeview_header :
    Before:
    treeviewbefor
    After : including fix for handles
    treeviewafter
    I changed 1 assets file with minor tweaks to gtkrc + main.rc
    If you approve I need to send that asset file (png) and the tweaking details.
    Example for treeview before :
    before
    After :
    after

Most helpful comment

@Paz-it We simply disagree here. IMO the before picture looks better.

I do like the scrollbars - is you can open a PR for it, that would be great.

All 13 comments

The headers should be white @Paz-it See this issue: https://github.com/ubuntu/yaru/issues/467

@madsrh , The color is VERY subtle, almost white but no problem to change it to complete white. The most important change is the clean look without extra unnecessary lines on top/bottom/lett/right preventing that clutter look.

The problem is that GTK2 must adhere with GTK3

image

moreover, the headerbar in this PR looks outside of the table to me and breaks the notebook view

I understand but the gtk3 looks much cleaner.
in this condition I think it is even more broken.
look at it again here :
before
In audacious you can hide the headerbar but in some other places you can't.
The subtle color can be changed to #ffffff instead of #f5f6f7 if necessary.
I did it for myself because it really disturbs :roll_eyes:

That's probably a misuse of treeview headerbar in audacious. The reason why headerbar is white is exactly because sometimes they are inside a notebook tab, which is all white itself. A different color would break the view

Like I said to @madsrh the color is not the main issue. the most annoying and aesthetic issue is the extra unnecessary lines on top/bottom/lett/right that makes it look cluttered.
Here you can see the before and after in Gpick:
before1
after1
and in Gimp :
before2
after2
I also changed the scrollbar-through color and reduced it's size but that's beside point now.

@Paz-it We simply disagree here. IMO the before picture looks better.

I do like the scrollbars - is you can open a PR for it, that would be great.

Last try with all white treeview-headerbar and sccrollbar-through white background :
screenshot from 2018-09-29 19-51-21
WDYT? :thinking:

I would like to see it with the gtk2 test app. Could you open a PR with this change?

Gtk2 test app :
screenshot from 2018-09-29 20-45-14
Can't open a PR , Sorry. there must be some other way,

I'm unsure, headerbar in awf is not ideal

@clobrano ,The awf is not giving you the full perspective because it's a kind of stand-alone widget without the window-frame it belongs to but if you feel it's not fit let's close it.

Let's close this and continue to #908

Was this page helpful?
0 / 5 - 0 ratings