Yaru: Volume icons are a mixture of symbolic and app-style

[matthewpaulthomas]

yaru-theme-* 18.10.4, Ubuntu Cosmic

1. Connect to a large office’s wi-fi.
2. In the Files sidebar, click “Other Locations”.

What you see: something like this.

What you should see: All the volume icons are of the same style.

This might just be two missing icons.

[[Originally reported in the Yaru forum](https://discourse.ubuntu.com/t/call-for-participation-an-ubuntu-default-theme-lead-by-the-community/1545/1750).]

[Feichtmeier]

Edit: removed to clear up my mind-fart moment

Could we open this on Suru and close this one here? @matthewpaulthomas
(Maybe I do it later)

[Feichtmeier]

Ah I misunderstood

So for clarification, these are the symbolic icons for places and devices:

So I guess we need that symbolic globe also for "windows-network" and the harddisk icon for the harddisk icon, is that what you meant, @matthewpaulthomas ?

[matthewpaulthomas]

The opposite, actually! This is the main pane, not the sidebar. The sidebar always uses symbolic icons, and — except for this bug — it’s the _only_ place I’ve seen symbolic filesystem icons. So it looks like some non-symbolic icons that are missing.

[Feichtmeier]

Ahhh! Lol - that's a weird screenshot! :D
Thanks for your response! I'll try to fix it

[Feichtmeier]

Hm hm hm
This is my nautilus -> other locations window
With
1) webdav mount
2) file share from a second computer named PONY :D (My daughters)

It is definitely not Suru. It is a humanity fallback I believe

@ubuntujaggers
The icon is called "network-server.svg" and it is def missing in Suru
Can you create one? :) I think this would fix one of the icons then we can further investigate

(Left is suru/yaru, right is humanity)

[Feichtmeier]

There is another icon missing @ubuntujaggers

I think I already created an issue about this one in Suru but ... well.. that doesn't help here much.
It is called
network.svg
network_fs.svg
network-workgroup.svg
gtk-network.svg
gnome-fs-network.svg .... holy crap... best would be if you open /usr/share/icons/humanity and search for network ... lot's of symlinks. But basically two icons are missing. The one with the plug in on the folder and network-server

[ubuntujaggers]

No probs, I'll do some Inkscape this weekend :)

[ubuntujaggers]

Okay, I've been trying to work out what's going on with the plug on the folder.

I think Suru generates icons by taking a symbol from source-symbolic.svg, colouring it, and putting it on a folder. Certainly, the music folder icon, home folder icon, etc., looks like that's happening. @Feichtmeier, does that fit with your understanding of the script and folder icons? I think the answer is for me to make a symbol for "network" and add it to source-symbolic.svg with that name...? It could be a monochrome glyph of an ethernet socket.

[ubuntujaggers]

Maybe the server stack icon could take the same shape as the trashcan and other "tall" Suru icons. Attempt no. 1:

Looks a bit cheap...

[Feichtmeier]

I think this is how it works but didn't dig into it. But just provide the icons and I do the rest :D
I think this looks not cheap. I like it no idea what others think

[ubuntujaggers]

For a network folder symbolic icon then, how about something like (far right, bottom row):

This would be consistent with other icons that put something on a folder:

Alternatively: we could just copy one of the other ones (the globe or the sharing glyph would work) to a new position in the source file and call the copy "network". Then hopefully it will be picked up for network place folders?

[ubuntujaggers]

I think this is how it works but didn't dig into it. But just provide the icons and I do the rest :D
I think this looks not cheap. I like it no idea what others think

I think it looks better than a completely non-Suru icon as a fallback, if you all like it I can do a PR :)

EDIT: Or suggestions for improvements welcome.

[Feichtmeier]

Yes! I like both, let's wait for @mads and @clobrano if they like it

[clobrano]

I like to keep the special icon for network server and use the glyph for the network folder :+1:

[Feichtmeier]

@ubuntujaggers not to hurry you but to clear out an eventual wrong communication I did with all those "icons missing"
You would "only" need to provide the two icons (server + network folder) and I do the symlinking for you :smiley_cat:
Because there are really a lot of those icons who use either of the two in humanity

[ubuntujaggers]

Okay, super, I'll square this one off today as well 👍

Network folder will mean adding/naming a new glyph on the symbolic source file, last time I was just changing one. I'll call it "network" unless anyone knows it should be called something different?

[Feichtmeier]

sounds good to me! I think I've read that name also in humanity

[ubuntujaggers]

One more question: am I doing "network-server" (the full colour server icon) in "places" or "devices"? Ready to PR as soon as I know...

[Feichtmeier]

I'd say places, because the symbolic is also in places

[Feichtmeier]

Fixed