Yaru: Some electron based applications use a white menu background color

[otavioschwanck]

Atom and Visual Studio Code have a white toolbat, making very ugly to look.

Other GTK 2 applications like franz, work nice:

But, when try to change theme to adwaita, it have a black toolbar, even when i restart the application.

[Feichtmeier]

Hi thanks for reporting.

Both are based on electron, and are now using gtk3 =)
Just for the record!

Doesn't reduce the fact that they have the wrong color ofc :)

[Paz-it]

That's an anomaly I see when on communitheme snap with some applications,Gtk2 apps included. While trying to change theme some parts of communitheme are still present. It looks like a bug in snap session.
@otavioschwanck , are you seeing this issue using snap session?

[otavioschwanck]

@Paz-it yes, using snap session. I'll try gnome session and Ubuntu session with XORG \ Wayland. Report here soon.

[otavioschwanck]

@Paz-it same results in all sessions.

New informations:

• On Arc Darker Theme, same result. White Toolbar on Atom \ VSCode.
• The ambiance theme is the only fine. Black toolbar on VSCODE \ Atom and Franz.

Ambiance:

Arc Darker:

i installed ubuntu 2 days ago.
In this two days, the VSCODE \ Atom bar are black on communittheme. Today i upgraded my system and the bar is white.

New information:

VS Code in ElementaryOS after upgrade, changed the toolbar to the inverse color, like in communittheme. Maybe is a electron issue?

[clobrano]

Gtk2 apps included. While trying to change theme some parts of communitheme are still present

Have you tried rebooting Gnome shell? Those might be server side decorations that don't go away otherwise

[otavioschwanck]

@clobrano yes. Rebooted gnome shell in every change using "r". Also rebooted the system too. Problem persist.

[clobrano]

@otavioschwanck Ok, @Paz-it you did the same?

[Feichtmeier]

The menus are also white with the .deb version of atom.

But maybe we should first check if "they" really suck up the gtk code for the menus :)

[otavioschwanck]

I'm using a deb version of atom, vscode and franz.

[Paz-it]

@clobrano Yes, I did the same.

[Feichtmeier]

I don't understand this...

Electron uses GTK3 dialogues now.
But is it possible that the menu is still styled with gtk2 styling? :thinking:

[Eskander]

Same here. Using communitheme snap, vscode (deb) shows a white menu bar.

Not sure if it helps but the menu bar follows _Adwaita-dark_ theme.

[clobrano]

Both are based on electron, and are now using gtk3

@Feichtmeier when did this change happen? I remember electron apps where styled after gtk2

[Feichtmeier]

@clobrano some weeks ago

[clobrano]

Weird, because in #728 menu bar works like it's using GTK2 colors

[Feichtmeier]

Prbly because they didn't merge the newer electron code yet :D

But anyways I don't know why for example atom, which clearly uses the gtk3 filechoser , doesnt use our menu colour

[clobrano]

@otavioschwanck

VS Code in ElementaryOS after upgrade, changed the toolbar to the inverse color, like in communittheme. Maybe is a electron issue?

not sure if I understood. Who changed the toolbar?

[clobrano]

However, electron project opened a bug about this and there's a PR in progress, so I guess it's an upstream issue

https://github.com/electron/electron/issues/13381

[Feichtmeier]

I'd say let's close this here then? :) If it's handled upstream

[clobrano]

The fix was merged https://github.com/electron/electron/pull/14785

[Feichtmeier]

@clobrano
Funny random coincidence, this would be fixed by the jet menus =)
https://discourse.ubuntu.com/t/mockups-new-design-discussions/1898/311

[Feichtmeier]

Since the fix is in electron let's close it here