Yaru: Support for Unity7

[khurshid-alam]

Yaru gtk theme is missing unity specific styles. For unity support take a look in Ambiance source

https://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk/view/head:/Ambiance/gtk-3.20/apps/unity.css

Or at Numix source:
https://github.com/numixproject/numix-gtk-theme/blob/master/src/gtk-3.20/scss/apps/_unity.scss

Styles for window buttons (for unity-panel) and unity-launcher can also be provided in Yaru. But it is not mandatory.

Thanks.

[Feichtmeier]

Hi @khurshid-alam thanks for the great links.

We come to can tackle this when there is some spare time - probably after 18.10 UI freeze

[madsrh]

prio-low

but any code contributions are more than welcome @khurshid-alam 😉

[eaglersdeveloper]

18.10 UI freeze

When it will be?

[madsrh]

When it will be?

One month from now 📆

https://wiki.ubuntu.com/CosmicCuttlefish/ReleaseSchedule

[Feichtmeier]

Just a little update, I work on this atm - no promise that I succeed =)

Problematic is still that unity7 CSD patch : / if that one would be dropped, I think this could be quiet easy.

[godlyranchdressing]

@Feichtmeier you should push and make a PR. I can help out with this one. I did it before, it's mostly the Unity 7 specific styling you'll need to grab from another theme and update to match Yaru. Then the SVG assets that Unity 7 looks for for the dash and elsewhere will need to be updated too.

[khurshid-alam]

I don't mind title-bar being dark for Light variant as well. Use $headerbar_bg_colorfor it and same for Panel.

Unity doesn't really have a csd patch. It installs gtk3-nocsd. All it does is remove the close button from headerbar and put a tiitlebar above it.

And, no, it can't be dropped.

[Feichtmeier]

Ohh! Great!:D

I am not with a pc ATM but I didn't do much yet. Only pasted the code from above into _apps.scss and changed the panel bg/colour to the shell panel colour and removed all that shadow and sunken effects. If you have time this evening just make another PR :D

[Feichtmeier]

Pushed the branch @godlyranchdressing

[fitojb]

FYI https://wiki.ubuntu.com/Unity/Theming

[godlyranchdressing]

I've done some work on this (the Unity panel looks fine), but for some reason not everything looks as it should. Padding and margins are all over the place and I just remembered that Unity might be using an older version of GTK3. Could that be the issue?

[Feichtmeier]

That could be. There is a new folder for Gtk 3.18
https://github.com/ubuntu/yaru/pull/935

[luispabon]

You peeps made any further progress on this? :smile:

[Feichtmeier]

I think @godlyranchdressing is right, maybe the new 3.18 folder is the place to look at
But to answer @luispabon it's still kind of low prio for me. We keep it opened but I need a separate VM for this and currently we have lot of stuff to do (disco on the horizon)

[luispabon]

Understood, and thank you :+1:

[Feichtmeier]

@khurshid-alam okay worked a bit on it and i could style everything except those incidcators, they stay gray, but also in ambiance, any tips?

[khurshid-alam]

@Feichtmeier

Nice !

Which icon theme you are using ? You need to use ubuntu-mono-dark for dark panel.

[luispabon]

Maybe need to look at tweaking the top bar to choose the right icons in yaru, or adding to yaru the icons that are missing - these all look like fallback icons to me.

[Feichtmeier]

Yup the icon theme did the trick

Someone would have to draw "yaru title button assets" though.

[YamiYukiSenpai]

Oh that looks amazing
Would love to see this become a default on Unity!

[joaopauloalbq]

The titlebar and header bar (or toolbar) should match.