Yaru: GTK2 theming has some glitches

[Feichtmeier]

I marked the regions which seem to be a bit messed up in the screenshots, I hope you can use this information :) Freaking awesome theme!

Gimp and Inkscape have some strange shadows in most widgets
And intellij IDEA, which uses swing for it's gui, which can use gtk2 theming, has a weird menu bar (grey on black)

[Feichtmeier]

The gimp and inkscape issues went away after installing:

sudo apt-get install gtk2-engines-pixbuf

The intellij menubar is still dark on black background though

[ya-d]

Installing pixbuf engine fixes most severe theming issues. Without it most buttons are not themed at all, so it should there by default.
Without pixbuf menu bar entries have a solid orange background and arrows are too big. With pixbuf installed menu bar entries have the brighter white font but are not always underlined (they are in Audacity but not in Scribus (maybe because of qt underlines letters for shortcuts?)). Arrows are all right now but e.g. check marks are still not themed.

[giovannicaligaris]

I think gtk2-engines-pixbuf should a dependency when installing communitheme.

[clobrano]

@ya-d is the problem fixed installing pixbuf engine? Or there are other main issues?

[Feichtmeier]

Edit: wow! Updated from the ppa and you fixed most of it!

The menubar is now with the correct foreground color which also affects the electron issue
https://github.com/Ubuntu/gtk-communitheme/issues/148

GTK2 theming also themes the Java Swing theme.

For example Intellij IDEA is based on swing and the latest update fixed the wrong menu colors, too.

Yet one little issue remains for java swing:

• when you select one of the menubar items, the background turns grey, yet the foreground stays white
  

[Feichtmeier]

I found two more issues in the GTK2 java swing theming:

1) the orange highlight color is very hard to see with that dark grey foreground - since the orange should not be changed, I would suggest changing the foreground color to white:

2) The textfields look somehow unthemed

[ya-d]

Looks much more complete with the latest updates! 👍 Great to see how far you've come, keep it up guys!

Some very minor glitches (not sure which of those can be themed anyway):

• radio button has check mark instead of point
• spinner isn't themed
• most focus rings are lacking: entry fields with connected buttons aren't closed on the right; buttons have inner grey ring instead of outer orange one; for check/radio buttons only the text label is highlighted in grey; links, sliders, cells, lists, tabs are grey
• toggled button lacks 3d effect (and only being darker doesn't indicate toggled state to me)
• disabled entry fields have lighter border which is also squared and blurry (especially noticeable for entry fields connected with dropdown list or up/down arrows)
• Are QT-apps related to gtk2? Scribus shows only check marks without border in its menu bars which makes them hard to recognize as toggles.

[Feichtmeier]

I have found one more issue in GTK2 file open dialog. There are 0 lines between the elements or any seperation. Really hard to spot anything @clobrano

[clobrano]

@Feichtmeier is this 17.10 or 18.04?

[Feichtmeier]

18.04
I recently updated because you talked about updating on the ubuntu forums =)

[clobrano]

@didrocks talked about updating some dependencies, but I don't think that happened yet. That might be a problem, I need a VM for working on both :cry:

[Feichtmeier]

Hm or just announce that it will only support 18.04 soon? In the end 17.10 won't have a long support anyways.

[didrocks]

Just be aware that once we do the switch, the packages won't work on artful anymore (both Shell and GTK).

The Shell project may break as well due to missing styles on artful (didn't test, but the OSK classes have been renamed).

[pojntfx]

Had this problem on Bionic before as well, but it seems to be fixed after I've updated today. The new button design however only seems to be applied to the GTK3 theme, but I can't help but just love the new grey accent in the GTK2 theme now. Also, the low contrast headerbars have been fixed (VSCode)!

[madsrh]

In Bionic:

[godlyranchdressing]

The new button design however only seems to be applied to the GTK3 theme

@pojntfx Sorry about that. After the button overhaul I just figured it'd be best to wait till the GTK3 theme gets the final signoff.

[Feichtmeier]

We miss the round corners for the bottom edge for none csd menus and all four round corners for CSD menus. And is a shadow possible like in the gtk3 theme? @godlyranchdressing @CDrummond

[CDrummond]

@Feichtmeier sorry, I'm no Gtk2 expert, my previous Gtk2 'fix' for Qt scrollbars was just a quick hack. To be honest, I'm not sure if Gtk2 can have rounded menus. Seeing as Gtk is advancing to Gtk4, I personally think its not worth spending lots of time with Gtk2. Just make it good enough - an exact 1:1 with Gtk3 is just not possible (e.g. scrollbars)

[Feichtmeier]

@Paz-it could you check this issue and see if you can do anything about it?

The worst part of gtk2 is that it even looks differently from application to application!

Java swing uses some engine that others don't use? :man_shrugging:

If it would be only gimp and inkscape I'd say "forget it" since they switch to gtk3 soon but the java swing and Qt theming which takes the gtk2 theming ... that's kind of important.

If you take intellij as an example... ambiance just looks perfectly! with intellij. Perfet in terms of "consistent" and no bugs

[Feichtmeier]

@flexiondotorg

We have still a problem with the Java swing gtk2 theming here. Could you take a look into it? Especially the menu bar on Java swing applications that use the gtk2 theme. I don't even know which theme engine Java uses but you can try it in Intellij's IDEA

[Paz-it]

@Feichtmeier
Sorry! I'm so bad in following here... anyway just saw it and going to read it https://bbs.archlinux.org/viewtopic.php?id=72892 <<<https://askubuntu.com/questions/21886/how-can-i-get-a-java-apps-to-use-the-gtk-theme...
You may know better then me what are they talking about . I know nothing about Java apps.
...

[Feichtmeier]

i will close this one and make a more precise issue