Yarn: How should `BlockView` arguments be named?

Created on 8 Feb 2020  路  6Comments  路  Source: FabricMC/yarn

BlockView arguments should be named view or world?

discussion vote
Source
picture LambdAurora

Most helpful comment

Result is pretty clear. people support world overwhelmingly, and let's just use world

picture liach on 8 Feb 2020
👍3

All 6 comments

I personally like world for all the world-like parameters

Prospector picture Prospector on 8 Feb 2020
👍1

I prefer view. Guess we can vote on this comment (:+1: and :-1:)

liach picture liach on 8 Feb 2020
👎7

Hm, aren't some of the *View interfaces only implemented on World and some implemented on Chunk as well?

Juuxel picture Juuxel on 8 Feb 2020
👍1

BlockView is implemented in something for rendering, worlds and chunks.
But WorldView is only implemented by world.

LambdAurora picture LambdAurora on 8 Feb 2020

Result is pretty clear. people support world overwhelmingly, and let's just use world

liach picture liach on 8 Feb 2020
👍3

Closing as we've decided and have applied to #1095.

liach picture liach on 9 Feb 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Runemoro picture Runemoro  路  3Comments
asiekierka picture asiekierka  路  4Comments
ChloeDawn picture ChloeDawn  路  6Comments
quat1024 picture quat1024  路  6Comments
Juuxel picture Juuxel  路  5Comments