Yarn: net.minecraft.client.model.Cuboid -> ModelPart

Created on 5 Aug 2019  路  3Comments  路  Source: FabricMC/yarn

It's not a cuboid, it can be composed of several boxes and has rotation point information. Then, net.minecraft.client.model.Box (which actually is a cuboid shape) should be renamed to Cuboid to avoid conflicting with net.minecraft.util.math.Box.

All 3 comments

Would even just Part be too generic? Seems a bit strange to have a model prefix when nothing else really does

I wouldn't change Box. Box is the perfect name for it.

ModelPart is okay, though I'd suggest the variationsModelSubPart, SubPart.

Other names like BoxSet, BoxList, RotatedBoxSet and RotatedBoxList all fit as well.

The model Box name is not great, because it conflicts with the utility box. And it never contains anything, so I think Cuboid is more appropriate.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Draylar picture Draylar  路  6Comments

Bixilon picture Bixilon  路  5Comments

quat1024 picture quat1024  路  3Comments

ChloeDawn picture ChloeDawn  路  5Comments

Awakened-Redstone picture Awakened-Redstone  路  4Comments